Add Node processing and physics processing cumulative (as opposed to delta) time

[MohammadKhashashneh]

This includes the following new functions:

• get_physics_process_cumulative_time()
  get_process_cumulative_time()
  Both return the cumulative time this node has been processing . Affected by the Node's pause state

• get_physics_process_total_time()
  get_process_total_time()
  Both return the total time this tree has been processing regardless of the Node's paused state.

Bugsquad edit: This closes #6999.

[MohammadKhashashneh]

This should fix issue #6999

[aaronfranke]

Affected by / regardless of the pause state? I wonder if #39606 will affect this.

[MohammadKhashashneh]

Affected by / regardless of the pause state? I wonder if #39606 will affect this.

I tested it against your branch and fortunately it seems to be working fine.

[Calinou]

The feature and documentation look good to me, but I'm a bit perplexed about the timers starting at 1.0.

[Calinou]

Tested locally, it works as expected:

time.mp4

Testing project: test_cumulative_time.zip

[Calinou]

Thanks!

This PR will need a dedicated version for 3.x, as it is not trivial to cherry-pick.

[reduz]

I am not in favor of merging this, It's extremely easy to workaround with a line of script, plus it's confusing whether what kind of cumulative time it refers to.

[reduz]

I suggest more discussion happens on this before a decision is made, but as-is, this is just far too easy to work around with a line of script, and too rarely needed to justify additions into core (which must be kept as bloat-free as possible).

[MohammadKhashashneh]

@reduz well noted.
To tell you the truth, I would use such a feature if available out of the box to implement some synchronized or realtime-like behavior such as the ones in rhythm games. HOWEVER, it can be done using a script in a node not affected by pause.
Anyways, it's still here if ever needed again, and will create a PR for the 3.x branch then :)

[reduz]

@MohammadKhashashneh No worries, still thanks for taking the effort of doing a PR and dont feel discouraged! We are discussing some more QOL features for rythm games that hope will prove useful in the future.

[MohammadKhashashneh]

@MohammadKhashashneh No worries, still thanks for taking the effort of doing a PR and dont feel discouraged! We are discussing some more QOL features for rythm games that hope will prove useful in the future.

@reduz Thank you and the rest of the crew for all your efforts :) and of course! not discouraged at all. I'm checking out what I can do next ;)