Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to 'header_separator' requiring an extra space #44121

Closed
wants to merge 1 commit into from
Closed

fix to 'header_separator' requiring an extra space #44121

wants to merge 1 commit into from

Conversation

quendera
Copy link
Contributor

@quendera quendera commented Dec 5, 2020

The HTTP spec does not require this extra space and, therefore, it causes problems even with properly typed code - when on web export.

@quendera
fix to 'header_separator' requiring an extra space
ece0823 
The HTTP spec does not require this extra space and it causes problems even with properly typed code when on web export.
@akien-mga akien-mga mentioned this pull request Dec 5, 2020
Closed
@akien-mga akien-mga added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release platform:web topic:porting labels Dec 5, 2020
@akien-mga akien-mga requested a review from Faless December 5, 2020 15:56
@akien-mga akien-mga added this to the 4.0 milestone Dec 5, 2020
Faless
Faless requested changes Dec 5, 2020
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmhhh.. I think we will need to trim the values, either in C++ or JS

@akien-mga
Copy link
Member

Mmmhhh.. I think we will need to trim the values, either in C++ or JS

@quendera Is this something you can implement?
Or do you want to do it @Faless?

@akien-mga akien-mga requested a review from Faless February 25, 2021 17:28
@Faless
Copy link
Collaborator

Faless commented Mar 8, 2021

Superseded by #46728

@Faless Faless closed this Mar 8, 2021
@akien-mga akien-mga added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Faless Faless Awaiting requested review from Faless

Assignees
No one assigned
Labels
archived bug platform:web topic:porting
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@quendera @akien-mga @Faless