Decrease the editor FPS limit when unfocused from 20 to 10 #47813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides better power savings compared to the previous value. This also speeds up project execution slightly while the editor is running in the background. The setting hint can now go as low as 1 FPS (1 million microseconds per frame), for those who really need the best possible power savings. This will make previewing animated shaders or particles impossible when the editor window isn't focused though.
Calinou
added
cherrypick:3.x
aaronfranke
reviewed
Apr 13, 2021
| // (but don't need to preview particles or shaders while the editor is unfocused). | ||
| // With very low FPS limits, the editor can take a small while to become usable after being focused again, | ||
| // so this should be used at the user's discretion. | ||
| hints["interface/editor/unfocused_low_processor_mode_sleep_usec"] = PropertyInfo(Variant::FLOAT, "interface/editor/unfocused_low_processor_mode_sleep_usec", PROPERTY_HINT_RANGE, "1,1000000,1", PROPERTY_USAGE_DEFAULT | PROPERTY_USAGE_RESTART_IF_CHANGED); |
There was a problem hiding this comment.
Should 0 also be allowed, to allow the editor to not have any speed limits when unfocused?
There was a problem hiding this comment.
If you set it to 1 microsecond, that's pretty much what happens already 🙂
There is no application that can run at more than 1 million FPS yet, not even glxgears on a RTX 3090.
akien-mga
approved these changes
Jun 17, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #47812.
This provides better power savings compared to the previous value. This also speeds up project execution slightly while the editor is running in the background.
The setting hint can now go as low as 1 FPS (1 million microseconds per frame), for those who really need the best possible power savings. This will make previewing animated shaders or particles impossible when the editor window isn't focused though.