Fix usage of String.left() #48927
Merged
Fix usage of String.left() #48927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 21, 2021
core/string/ustring.cpp
Outdated
| @@ -939,6 +939,7 @@ const char32_t *String::get_data() const { | |||
| } | |||
|
|
|||
| void String::erase(int p_pos, int p_chars) { | |||
| p_pos = MAX(p_pos, 0); | |||
There was a problem hiding this comment.
Should it fail on negative indices instead?
There was a problem hiding this comment.
I could change it to fail, I just wanted to preserve the previous behavior.
kleonc
reviewed
May 21, 2021
akien-mga
approved these changes
May 22, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36180 changed behavior of negative arguments in
left(). Previously it would return empty string. Some code relied on that behavior, so this PR fixes it.*Bugsquad edit: This closes #48951.