Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C# file extension not appearing in Search in File Extensions default #49047

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 24, 2021

I'm not sure if this is a proper fix, but it seems the code path isn't being triggered correctly according to the proposal.

This closes godotengine/godot-proposals#2766.

@Calinou Calinou added bug cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:editor topic:dotnet labels May 24, 2021
@Calinou Calinou added this to the 4.0 milestone May 24, 2021
@Calinou Calinou requested a review from neikeq May 24, 2021 21:06
@neikeq
Copy link
Contributor

neikeq commented Jun 2, 2021

Last time I checked MODULE_*_ENABLED are only defined inside modules/ sources, did this change?
I'm wondering why the GodotSharp singleton isn't present though as we register it here:

Engine::get_singleton()->add_singleton(Engine::Singleton("GodotSharp", _GodotSharp::get_singleton()));

Is the ProjectSettings constructor being called before register_module_types?

@mysliwy112
Copy link

As far as I tested using Engine.HasSingleton("GodotSharp") in C# returns True when running game through Godot Mono.

@neikeq
Copy link
Contributor

neikeq commented Jun 2, 2021

So apparently ProjectSettings constructor is called before register_module_types, so that explain why the singleton is not present yet.

@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Feb 12, 2023
@AThousandShips
Copy link
Member

Is this still relevant? Several changes have been made since this, most recently:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:3.x Considered for cherry-picking into a future 3.x release needs work topic:dotnet topic:editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Find in Files work with more file types (mainly CS)
6 participants