-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Fix the editor theme application for the Mono build log #51221
Conversation
6016fbb
to
3857fd5
Compare
Thanks! |
Should this be found in 3.3.3? This seems to have been merged at aug 3, 3.3.3 according to the website was released on aug 19; but it still has the illegible output panel in light theme. |
@Flavelius The 3.x branch will become 3.4, not the next 3.3.x release. The 3.3 branch is for the next 3.3.x release, but this PR has not been cherry-picked to the 3.3 branch. We can still do that for 3.3.4 if this feature is known to not cause regressions and there is consensus that it should be backported. Typically 3.3.x primarily gets bugfixes since it's the stable branch. |
It should be okay to cherrypick for the next 3.3 release, I think. |
If this is cherry-picked, #51325 should be cherry-picked too. |
Edit: Undone, as this doesn't build as is. |
So this probably requires a dedicated PR if wanted in
|
A
3.x
version of #51220.