Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix the editor theme application for the Mono build log #51221

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

YuriSizov
Copy link
Contributor

A 3.x version of #51220.

@YuriSizov YuriSizov added this to the 3.4 milestone Aug 3, 2021
@YuriSizov YuriSizov requested a review from neikeq August 3, 2021 18:57
@YuriSizov YuriSizov requested a review from a team as a code owner August 3, 2021 18:57
@YuriSizov YuriSizov marked this pull request as draft August 3, 2021 19:10
@YuriSizov YuriSizov force-pushed the editor-mono-build-log-3.x branch from 6016fbb to 3857fd5 Compare August 3, 2021 19:11
@YuriSizov YuriSizov marked this pull request as ready for review August 3, 2021 19:12
@akien-mga akien-mga merged commit d9a07d1 into godotengine:3.x Aug 3, 2021
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov deleted the editor-mono-build-log-3.x branch August 3, 2021 20:04
@Flavelius
Copy link
Contributor

Should this be found in 3.3.3? This seems to have been merged at aug 3, 3.3.3 according to the website was released on aug 19; but it still has the illegible output panel in light theme.

@aaronfranke
Copy link
Member

@Flavelius The 3.x branch will become 3.4, not the next 3.3.x release. The 3.3 branch is for the next 3.3.x release, but this PR has not been cherry-picked to the 3.3 branch. We can still do that for 3.3.4 if this feature is known to not cause regressions and there is consensus that it should be backported. Typically 3.3.x primarily gets bugfixes since it's the stable branch.

@YuriSizov
Copy link
Contributor Author

It should be okay to cherrypick for the next 3.3 release, I think.

@raulsntos
Copy link
Member

If this is cherry-picked, #51325 should be cherry-picked too.

@akien-mga
Copy link
Member

akien-mga commented Sep 29, 2021

Cherry-picked for 3.3.4.

Edit: Undone, as this doesn't build as is.

@akien-mga
Copy link
Member

So this probably requires a dedicated PR if wanted in 3.3 as there's too many issues for me to cherry-pick it safely without risk of breakage:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants