Improve collision generation usability in the new 3D scene import workflow. #52266

AndreaCatania · 2021-08-30T19:11:28Z

Mirror of: #51985 that was merged for mistake.

Implements the proposal: godotengine/godot-proposals#3155

With this PR it's possible to add a collision during the Mesh import, directly in editor.
To generate the shape is possible to chose between the following options:

Decompose Convex: The Mesh is decomposed in one or many Convex Shapes (Using the VHACD library).
Simple Convex: Is generated a convex shape that enclose the entire mesh.
Trimesh: Generate a trimesh shape using the Mesh faces.
Box: Add a primitive box shape, where you can tweak the size, position, rotation.
Sphere: Add a primitive sphere shape, where you can tweak the radius, position, rotation.
Cylinder: Add a primitive cylinder shape, where you can tweak the height, radius, position, rotation.
Capsule: Add a primitive capsule shape, where you can tweak the height, radius, position, rotation.

It's also possible to chose the generated body, so you can create:

Rigid Body.
Static Body.
Area.

See it in action here: https://youtu.be/I-N1IXgeb00

2021-08-27.09-36-34.mp4

The constructor was expecting a mutable pointer, while the passed pointer was immutable (returns a const pointer), so the compilation was failing when iterating a constant.

reduz · 2021-09-06T15:32:41Z

editor/import/resource_importer_scene.cpp

+			// Decomposition
+			Mesh::ConvexDecompositionSettings decomposition_default;
+			r_options->push_back(ImportOption(PropertyInfo(Variant::BOOL, "decomposition/advanced", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_DEFAULT | PROPERTY_USAGE_UPDATE_ALL_IF_MODIFIED), false));
+			r_options->push_back(ImportOption(PropertyInfo(Variant::INT, "decomposition/precision", PROPERTY_HINT_RANGE, "1,10,1", PROPERTY_USAGE_DEFAULT | PROPERTY_USAGE_UPDATE_ALL_IF_MODIFIED), 5));


You probably don't need PROPERTY_USAGE_UPDATE_ALL_IF_MODIFIED modified for these. This flag is only for when changing the property results in other properties being added/removed/changed.

For advanced, I need it to make sure to show all the other properties, but for precision you right, I don't need it, nice catch!

reduz · 2021-09-06T15:33:59Z

editor/import/resource_importer_scene.cpp

@@ -980,6 +1017,65 @@ bool ResourceImporterScene::get_internal_option_visibility(InternalImportCategor
 		case INTERNAL_IMPORT_CATEGORY_NODE: {
 		} break;
 		case INTERNAL_IMPORT_CATEGORY_MESH_3D_NODE: {
+			const bool generate_physics =
+					p_options.has("generate/physics") &&


If I am not mistaken, using .has() is not needed, it is warranted that you will always get all the properties filled in (and if not there is likely a bug).

Calling .has() is necessary, to avoid crash the engine while using the constant version of operator[]: https://github.com/godotengine/godot/blob/master/core/templates/map.h#L662

reduz · 2021-09-06T15:37:08Z

editor/import/resource_importer_scene.cpp

@@ -1016,6 +1112,33 @@ bool ResourceImporterScene::get_internal_option_visibility(InternalImportCategor
 	return true;
 }

+bool ResourceImporterScene::get_internal_option_update_view(InternalImportCategory p_category, const String &p_option, const Map<StringName, Variant> &p_options) const {


may use a different function like get_internal_option_update_view_required to make it a bit clearer.

Yes, make sense, I'll change that

…kflow. With this PR it's possible to add a collision during the Mesh import, directly in editor. To generate the shape is possible to chose between the following options: - Decompose Convex: The Mesh is decomposed in one or many Convex Shapes (Using the VHACD library). - Simple Convex: Is generated a convex shape that enclose the entire mesh. - Trimesh: Generate a trimesh shape using the Mesh faces. - Box: Add a primitive box shape, where you can tweak the `size`, `position`, `rotation`. - Sphere: Add a primitive sphere shape, where you can tweak the `radius`, `position`, `rotation`. - Cylinder: Add a primitive cylinder shape, where you can tweak the `height`, `radius`, `position`, `rotation`. - Capsule: Add a primitive capsule shape, where you can tweak the `height`, `radius`, `position`, `rotation`. It's also possible to chose the generated body, so you can create: - Rigid Body - Static Body - Area

reduz · 2021-09-09T19:04:32Z

Looks awesome, if someone else wants to give it a check to give feedback (@fire and @JFonS ?) please be welcome to, otherwise will merge in the coming days.

fire · 2021-09-09T19:15:25Z

I checked the functionality of this previously. The changes to the default precision from 0 to 5+ and defaulting to convex decompose have been made.

We discussed how it was possible to make test cases for the matrix of cases.

Looks good to me.

fire · 2021-09-09T19:20:17Z

modules/vhacd/register_types.cpp

+	params.m_resolution = p_settings.resolution;
+	params.m_maxNumVerticesPerCH = p_settings.max_num_vertices_per_convex_hull;
+	params.m_planeDownsampling = p_settings.plane_downsampling;
+	params.m_convexhullDownsampling = p_settings.convexhull_downsampling;


wanted: spelling changes on convexhull vs convex_hull. I prefer "convex_hull". The usage is inconsistent.

This change should not block merge.

JFonS

Looks good :)

akien-mga · 2021-09-14T12:34:25Z

Thanks!

aaronfranke · 2021-10-05T00:06:01Z

This doesn't work with scaled meshes. It scales the physics body instead of the mesh, which breaks physics (see the ⚠️):

Fix Vector ConstIterator constructor.

3127cc4

The constructor was expecting a mutable pointer, while the passed pointer was immutable (returns a const pointer), so the compilation was failing when iterating a constant.

AndreaCatania added the feature proposal label Aug 30, 2021

AndreaCatania added this to the 4.0 milestone Aug 30, 2021

AndreaCatania requested a review from reduz August 30, 2021 19:11

AndreaCatania requested review from a team as code owners August 30, 2021 19:11

AndreaCatania added topic:editor topic:physics labels Aug 30, 2021

pouleyKetchoupp added the topic:3d label Aug 31, 2021

reduz requested changes Sep 6, 2021

View reviewed changes

AndreaCatania force-pushed the coll branch from cfa9224 to e3a06c3 Compare September 8, 2021 06:13

reduz approved these changes Sep 9, 2021

View reviewed changes

fire reviewed Sep 9, 2021

View reviewed changes

JFonS approved these changes Sep 10, 2021

View reviewed changes

akien-mga added the topic:import label Sep 14, 2021

akien-mga merged commit e13d8ed into godotengine:master Sep 14, 2021

AndreaCatania deleted the coll branch September 16, 2021 05:37

aaronfranke mentioned this pull request Oct 4, 2021

Allow importing 3D models without colliders or with KinematicBody/Area #39924

Closed

clayjohn mentioned this pull request Jan 19, 2023

Lightmap UV doesn't generate if physics body is enabled in blender import settings #64746

Closed

Malcolmnixon mentioned this pull request Jan 23, 2024

Crash when configuring the import of a gltf file and enabling Physics in a MeshInstance3D and switching body and shape types #85439

Closed

kitbdev mentioned this pull request Jan 14, 2025

Fix spinbox scrolling for advanced importer controls. #98016

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve collision generation usability in the new 3D scene import workflow. #52266

Improve collision generation usability in the new 3D scene import workflow. #52266

AndreaCatania commented Aug 30, 2021 •

edited

Loading

reduz Sep 6, 2021

AndreaCatania Sep 6, 2021

AndreaCatania Sep 8, 2021

reduz Sep 6, 2021

AndreaCatania Sep 8, 2021

reduz Sep 6, 2021

AndreaCatania Sep 6, 2021

AndreaCatania Sep 8, 2021

reduz commented Sep 9, 2021

fire commented Sep 9, 2021 •

edited

Loading

fire Sep 9, 2021 •

edited

Loading

JFonS left a comment

akien-mga commented Sep 14, 2021

aaronfranke commented Oct 5, 2021

Improve collision generation usability in the new 3D scene import workflow. #52266

Improve collision generation usability in the new 3D scene import workflow. #52266

Conversation

AndreaCatania commented Aug 30, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reduz commented Sep 9, 2021

fire commented Sep 9, 2021 • edited Loading

fire Sep 9, 2021 • edited Loading

Choose a reason for hiding this comment

JFonS left a comment

Choose a reason for hiding this comment

akien-mga commented Sep 14, 2021

aaronfranke commented Oct 5, 2021

AndreaCatania commented Aug 30, 2021 •

edited

Loading

fire commented Sep 9, 2021 •

edited

Loading

fire Sep 9, 2021 •

edited

Loading