Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Revert HTTPRequest gzip compression support. #53800

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Oct 14, 2021

Partial revert of commit c1135cf.

See: #48651 (comment)

#48651 causes a few regressions including #53085 so it needs to be reverted. The original PR on master #38944 is left for now but will need work if we want to keep in 4.0 (or will need revert too).

Issues:

  • Some platform/HTTPClient might not allow those headers (HTML5)
  • Response is not decompressed when saved to file.
  • We need facilities to decompress a stream (i.e. not decompress all in memory but in chunks to file).

I've left the changes adding request_raw and Compression::decompress_dynamic since they are both still needed anyway (and for now will allow to implement manual gzip decompression in 3.x).

@Faless Faless added this to the 3.4 milestone Oct 14, 2021
@Faless Faless requested review from a team as code owners October 14, 2021 10:59
@akien-mga akien-mga merged commit ff132ca into godotengine:3.x Oct 14, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants