Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Set DEBUG_ENABLED and DEV_ENABLED in SConstruct #53827

Merged

Conversation

akien-mga
Copy link
Member

They're the same for all platforms so they don't need to be repeated in all
platform definitions.

As discussed in #53799 (comment)

Also removes unused define, and replaces DISABLE_FORCED_INLINE by DEV_ENABLED since they're equivalent in this context.

@akien-mga akien-mga added this to the 4.0 milestone Oct 15, 2021
@akien-mga akien-mga requested a review from Faless October 15, 2021 07:31
@akien-mga akien-mga requested review from a team as code owners October 15, 2021 07:31
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Oct 15, 2021
They're the same for all platforms so they don't need to be repeated in all
platform definitions.
@akien-mga akien-mga force-pushed the scons-debug-dev-enabled-sconstruct branch from 23e6bd6 to cd21cc6 Compare October 15, 2021 08:27
@akien-mga akien-mga merged commit 25f89a8 into godotengine:master Oct 15, 2021
@akien-mga akien-mga deleted the scons-debug-dev-enabled-sconstruct branch October 15, 2021 10:41
@akien-mga
Copy link
Member Author

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant