Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added or improved function description and codeblocks in @GlobalScope.xml #54417

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

Anutrix
Copy link
Contributor

@Anutrix Anutrix commented Oct 30, 2021

Fixes #34351.

Added description to abs, clamp, sign and is_instance_id_valid in @GlobalScope.xml.

@Anutrix Anutrix requested a review from a team as a code owner October 30, 2021 12:14
@Anutrix Anutrix force-pushed the global-scope-doc-updates branch from dad414e to 8a9ea76 Compare October 30, 2021 12:18
@YuriSizov YuriSizov added this to the 4.0 milestone Oct 30, 2021
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks for style consistency, otherwise looks good!

@Anutrix Anutrix force-pushed the global-scope-doc-updates branch from 8a9ea76 to 243677a Compare November 6, 2021 13:49
@Anutrix Anutrix requested review from a team as code owners November 6, 2021 13:49
@Anutrix Anutrix force-pushed the global-scope-doc-updates branch from 243677a to 4212924 Compare November 6, 2021 14:18
@Anutrix
Copy link
Contributor Author

Anutrix commented Nov 6, 2021

Small nitpicks for style consistency, otherwise looks good!

Thx. Made changes and rebased.

@mhilbrunner mhilbrunner merged commit 4651b2a into godotengine:master Nov 6, 2021
@mhilbrunner
Copy link
Member

Thank you!

@Anutrix Anutrix deleted the global-scope-doc-updates branch July 26, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete abs() docs and editor hints
3 participants