Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show errors when getting nonexistent settings #55309

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

aaronfranke
Copy link
Member

Follow-up fix to #31171 and #55303. I was focused on getting it working last night but I forgot to check the console for errors. The current master does work except for the fact that it shows these errors:

ERROR: Property not found: application/config/features
   at: _get (core/config/project_settings.cpp:320)
ERROR: Property not found: rendering/quality/driver/driver_name
   at: _get (core/config/project_settings.cpp:320)

(btw, get_setting and set_setting seem to just be simple wrappers for get and set, but it's definitely good to use these for consistency with has_setting since there is no "has" without "_setting").

@akien-mga akien-mga merged commit b3ec5a1 into godotengine:master Nov 25, 2021
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the ps-exist-errors branch November 25, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants