-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate redundant fract_delta
property in GPUParticles
#55743
base: master
Are you sure you want to change the base?
Conversation
Note that #52846 now uses the I haven't yet investigated how the GPUParticles work or whether they could also do streaking (I'm sure it would be welcome there too if we can do it, although it doesn't have to be part of the interpolation PR). I don't know yet how the interpolation works in 4.x, whether it already can do this. |
@lawnjelly: fixed timestep interpolation for Godot 4 was implemented (#92391, #91818). A code search on Github says that |
Rebased and tested again, it works as expected. This now preserves compatibility by deprecating the property and hiding it from the inspector instead of removing it entirely.
I still think the property can be deprecated as I don't see any use cases to disabling it (unlike interpolation, which you may want to disable to sidestep rendering issues or have a retro look). |
This property was made redundant by the addition of interpolation in GPUParticles. It's now always enabled and hidden in the inspector. CPUParticles' `fract_delta` property is still effective after this change.
692ca8e
to
438329f
Compare
fract_delta
property in GPUParticlesfract_delta
property in GPUParticles
This property was made redundant by the addition of interpolation in GPUParticles. It's now always enabled.
CPUParticles still features a
fract_delta
property for now. Should we remove it as well?See discussion on the Godot Contributors Chat.