Automatically increase Light3D shadow bias when shadow blur is above 1.0 #55758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to adjust shadow blur without having to tweak bias to avoid shadow acne. The formula automatically increases shadow bias, normal bias and transmittance bias when shadow blur is above 1.0:
At the highest shadow blur value allowed in the inspector (8), the shadow bias and normal bias will each be multiplied by 5.5.
Automatic adjustment is not performed for PCSS-style shadow blur (light size > 0) yet.
This partially addresses #53534.
TODO
Preview
Note: The bias values used in the demo below are from #55757.
DirectionalLight3D
Visible lines between PSSM shadow splits will be attenuated if #48776 is merged.
Before
shadow_blur_directional_old2.mp4
After
shadow_blur_directional_new.mp4
OmniLight3D
Before
shadow_blur_omni_old2.mp4
After
shadow_blur_omni_new.mp4
SpotLight3D
Before
shadow_blur_spot_old2.mp4
After
shadow_blur_spot_new.mp4