Use is_zero_approx and fix spelling in CameraMatrix invert #58507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some problems noticed in #58492 (comment)
Math::absd
being used onreal_t
when it should beMath::abs
.is_zero_approx()
instead ofabsd() < 1e-7
since1e-7
is so small of an epsilon to the point of not being very useful (float
precision around 1 is 2^-23 or about1.192e-7
). It's possible that1e-7
works for this case, but if that is true, then why it's so small needs to be explained in a comment. This part needs review from @reduz.