Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MODEL_NORMAL_MATRIX in fragment function of spatial shader #59342

Closed
wants to merge 1 commit into from

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Mar 20, 2022

No description provided.

@Chaosus Chaosus requested a review from a team as a code owner March 20, 2022 06:40
@Chaosus Chaosus added this to the 4.0 milestone Mar 20, 2022
@Chaosus Chaosus requested a review from clayjohn March 20, 2022 06:41
@Chaosus Chaosus force-pushed the fix_model_normal_matrix branch from 051d6a2 to bc87476 Compare March 20, 2022 09:50
@clayjohn
Copy link
Member

This makes me realize that we need to re-evaluate what we are doing with the regular model matrix. Both the model matrix and the model_normal_matrix get adjusted by the multimesh transform (when uses multimeshes) But in the fragment shader the extra transform is not applied so the model_matrix won't match in the fragment and the vertex shaders.

@Chaosus
Copy link
Member Author

Chaosus commented Mar 29, 2022

@clayjohn Should I change something in this PR?

@clayjohn
Copy link
Member

@clayjohn Should I change something in this PR?

Not yet no. We need to discuss what we want to do with the regular matrix as right now the model_matrix will be different between the vertex shader and the fragment shader right now which is not good.

@clayjohn clayjohn modified the milestones: 4.0, 4.1 Feb 13, 2023
@clayjohn clayjohn modified the milestones: 4.1, 4.x May 23, 2023
@jsjtxietian
Copy link
Contributor

Should we delete the fragement MODEL_NORMAL_MATRIX part in documentaion for now ? Users will get confused : #85586

@Chaosus
Copy link
Member Author

Chaosus commented Jun 14, 2024

I've lost my thoughts about this PR, so I'll close it.

@Chaosus Chaosus closed this Jun 14, 2024
@Chaosus Chaosus deleted the fix_model_normal_matrix branch June 14, 2024 10:20
@AThousandShips AThousandShips removed this from the 4.x milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants