Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename or_lesser range property hint to or_less #59589

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 27, 2022

"less" should be used for quantity, rather than "lesser".

Existing scripts that use or_lesser in _get_property_list() will need to be updated to account for this change.

See #54161 (comment).

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

@akien-mga
Copy link
Member

Bump :)

"less" should be used for quantity, rather than "lesser".

Existing scripts that use `or_lesser` in `_get_property_list()`
will need to be updated to account for this change.
@Calinou
Copy link
Member Author

Calinou commented Sep 2, 2022

Rebased and tested again, it works as expected. I also renamed the internal properties as requested.

@Calinou Calinou force-pushed the rename-or-lesser-range-property-hint branch from ba7d924 to f7292db Compare September 2, 2022 17:08
@akien-mga akien-mga merged commit 77ca96f into godotengine:master Sep 2, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants