Improved drad&drop files on project manager #5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure, what to do with multiple_folders vector if user cancel scan, vector keep values, and only next dnd clear previous values |
| scan_dir->popup_centered_ratio(); | ||
| } | ||
|
|
||
| void ProjectManager::_scan_multiple_folders() |
There was a problem hiding this comment.
Wouldn't it be cleaner/simpler to just pass StringArray p_folders as argument here and drop the member var multiple_folders altogether?
profelis
force-pushed
the
PR-scan-dragged-folder-2
branch
from
f0f495b to
bee2091
Compare
|
Fixed all and squashed in one commit |
| @@ -1332,8 +1367,13 @@ ProjectManager::ProjectManager() { | |||
| multi_run_ask = memnew( ConfirmationDialog ); | |||
| multi_run_ask->get_ok()->set_text(TTR("Run")); | |||
| multi_run_ask->get_ok()->connect("pressed", this, "_run_project_confirm"); | |||
|
|
|||
There was a problem hiding this comment.
Beware of adding trailing spaces ;)
27thLiz
added a commit
to 27thLiz/godot
that referenced
this pull request
Aug 5, 2016
This has been deprecated by godotengine#5993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved dnd in project manager. Dragged any file from project folder or single project folder autoimport it, otherwise confirm scan all dragger folders.
Regarding #5981, @akien-mga please review.