[3.x] Add dedicated macros for property name extraction #61141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this also needed for subgroups and arrays? There are a few macros that don't seem to be included by
|
|
@fire-forge This is for |
* Replace case-by-case extraction with PNAME & GNAME * Fix group handling when group hint begins with property name * Exclude properties that are PROPERTY_USAGE_NOEDITOR
timothyqiu
force-pushed
the
property-extract-3.x
branch
from
c65b718 to
b657d0c
Compare
akien-mga
reviewed
May 19, 2022
| @@ -785,13 +785,13 @@ void register_scene_types() { | |||
| OS::get_singleton()->yield(); //may take time to init | |||
|
|
|||
| for (int i = 0; i < 20; i++) { | |||
| GLOBAL_DEF("layer_names/2d_render/layer_" + itos(i + 1), ""); | |||
| GLOBAL_DEF("layer_names/3d_render/layer_" + itos(i + 1), ""); | |||
| GLOBAL_DEF(vformat("%s/layer_%d", PNAME("layer_names/2d_render"), i + 1), ""); | |||
There was a problem hiding this comment.
Shouldn't you localize layer too?
There was a problem hiding this comment.
Since it's the formated string (layer_1 / Layer 1) that will be sent for localization. Translating layer alone won't work. It's currently a limitation.
akien-mga
approved these changes
May 19, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PNAME&GNAMEgodot/scene/resources/skin.cpp
Line 130 in e86d840
godot/servers/physics_server.cpp
Line 814 in e86d840
_get_property_list():godot/editor/plugins/tile_set_editor_plugin.cpp
Lines 3539 to 3545 in e86d840
PROPERTY_USAGE_NOEDITORI have a feeling that these are not good macro names. But I can't find a suitable short name for them currently. Any suggestions?