Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print messages when textures are detected as used in 3D/normal/roughness #61497

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 28, 2022

master version of #62004.

This detection automatically changes some import options, so it's important that users are aware of this.

Testing project: test_material_detect_3d.zip

Preview

Note: Normal map, ambient occlusion map and height map are all detected to be used as a roughness map, which is incorrect. The roughness map is not detected as being used as a roughness map.

res://ambientcg/Bricks079_2K_Color.jpg: Texture detected as used in 3D. Enabling mipmap generation and setting the texture compression mode to VRAM Compressed (S3TC/ETC/BPTC).
res://ambientcg/Bricks079_2K_Roughness.jpg: Texture detected as used in 3D. Enabling mipmap generation and setting the texture compression mode to VRAM Compressed (S3TC/ETC/BPTC).
res://ambientcg/Bricks079_2K_NormalGL.jpg: Texture detected as used as a normal map in 3D. Enabling red-green texture compression to reduce memory usage (blue channel is discarded).
res://ambientcg/Bricks079_2K_NormalGL.jpg: Texture detected as used as a roughness map in 3D. Enabling roughness limiter based on the detected associated normal map at res://ambientcg/Bricks079_2K_NormalGL.jpg.
res://ambientcg/Bricks079_2K_NormalGL.jpg: Texture detected as used in 3D. Enabling mipmap generation and setting the texture compression mode to VRAM Compressed (S3TC/ETC/BPTC).
res://ambientcg/Bricks079_2K_AmbientOcclusion.jpg: Texture detected as used as a roughness map in 3D. Enabling roughness limiter based on the detected associated normal map at res://ambientcg/Bricks079_2K_NormalGL.jpg.
res://ambientcg/Bricks079_2K_AmbientOcclusion.jpg: Texture detected as used in 3D. Enabling mipmap generation and setting the texture compression mode to VRAM Compressed (S3TC/ETC/BPTC).
res://ambientcg/Bricks079_2K_Displacement.jpg: Texture detected as used as a roughness map in 3D. Enabling roughness limiter based on the detected associated normal map at res://ambientcg/Bricks079_2K_NormalGL.jpg.
res://ambientcg/Bricks079_2K_Displacement.jpg: Texture detected as used in 3D. Enabling mipmap generation and setting the texture compression mode to VRAM Compressed (S3TC/ETC/BPTC).

This detection automatically changes some import options, so it's
important that users are aware of this.
@Calinou Calinou requested a review from a team as a code owner May 28, 2022 13:36
@Calinou Calinou added this to the 4.0 milestone May 28, 2022
@akien-mga akien-mga merged commit fc18891 into godotengine:master Jun 1, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants