Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node.remove_and_skip method #64412

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Aug 15, 2022

Closes godotengine/godot-proposals#4049

Closes #56905 (I guess..?)

The method is obscure as it's not needed often, and it fails to communicate its purpose well. For the most part, it can be re-implemented in 4-5 simple lines of GDScript even if you do need it, which I assume most users never have. Basically it goes against a requirement proposals today need to fulfill.

Had a chat about whether we should rename or outright remove it, the sentiment seemed to be towards the latter. Probably best to discuss further.

@MewPurPur MewPurPur requested review from a team as code owners August 15, 2022 00:16
@Chaosus Chaosus added this to the 4.0 milestone Aug 15, 2022
@MewPurPur MewPurPur force-pushed the remove-remove-and-skip branch 3 times, most recently from 150d62b to e33e6b6 Compare September 9, 2022 15:04
@akien-mga
Copy link
Member

You forgot to remove the binding.

@MewPurPur MewPurPur force-pushed the remove-remove-and-skip branch from e33e6b6 to e19f7b2 Compare September 9, 2022 21:44
@MewPurPur
Copy link
Contributor Author

Doned.

@akien-mga akien-mga merged commit 27e1323 into godotengine:master Sep 9, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants