Remove Node.remove_and_skip method
#64412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewPurPur
force-pushed
the
remove-remove-and-skip
branch
3 times, most recently
from
150d62b to
e33e6b6
Compare
akien-mga
approved these changes
Sep 9, 2022
|
You forgot to remove the binding. |
MewPurPur
force-pushed
the
remove-remove-and-skip
branch
from
e33e6b6 to
e19f7b2
Compare
|
Doned. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#4049
Closes #56905 (I guess..?)
The method is obscure as it's not needed often, and it fails to communicate its purpose well. For the most part, it can be re-implemented in 4-5 simple lines of GDScript even if you do need it, which I assume most users never have. Basically it goes against a requirement proposals today need to fulfill.
Had a chat about whether we should rename or outright remove it, the sentiment seemed to be towards the latter. Probably best to discuss further.