Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AABB/Rect2/Rect2i has_no_* methods with has_* methods #64417

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Replace AABB/Rect2/Rect2i has_no_* methods with has_* methods #64417

merged 3 commits into from
Sep 6, 2022

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Aug 15, 2022 •
edited
Loading

This PR does the following:

  • AABB: Replace has_no_volume with has_volume (the bool is inverted)
  • AABB: Replace has_no_surface with has_surface (the bool is inverted)
  • Rect2: Replace has_no_area with has_area (the bool is inverted)
  • Rect2i: Replace has_no_area with has_area (the bool is inverted)
  • Improve the documentation of these methods to be more clear and concise.

While working on #64416, I figured this would make sense to change, because otherwise we end up with double negatives.

@aaronfranke aaronfranke added this to the 4.0 milestone Aug 15, 2022
@aaronfranke aaronfranke requested review from a team as code owners August 15, 2022 04:51
@aaronfranke aaronfranke requested a review from a team as a code owner August 15, 2022 16:48
@aaronfranke aaronfranke force-pushed the has-space branch 2 times, most recently from fcd4ed6 to 1ca587a Compare August 18, 2022 20:12
@aaronfranke
Replace AABB has_no_volume with has_volume

Verified

This commit was signed with the committer’s verified signature.
adamscott Adam Scott
GPG key ID: F6BA2A0302E21A77
Verified
Learn about vigilant mode
Loading
Loading status checks…
817ae95 
Also replace has_no_surface with has_surface
@aaronfranke
Replace Rect2(i) has_no_area with has_area
995b9f9
@aaronfranke
Replace AABB/Rect2(i) HasNo* methods in C#
7c2f0a8
akien-mga
akien-mga approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in PR review meeting.

@akien-mga akien-mga merged commit 5062aaf into godotengine:master Sep 6, 2022
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the has-space branch September 6, 2022 15:59
@Mickeon Mickeon mentioned this pull request Nov 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos

@akien-mga akien-mga

Assignees
No one assigned
Labels
breaks compat enhancement topic:core
Projects
No open projects
Godot 4.0 API Renames Bikeshedder
Status: Approved
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronfranke @akien-mga @raulsntos