Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Misc docs and comment style and language fixes #68120

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Nov 1, 2022

  • Removed empty paragraphs in XML.
  • Consistently use bold style for "Example:", on a new line.
  • Fix usage of [code] when hyperlinks could be used ([member], [constant]).
  • Fix invalid usage of backticks for inline code in BBCode.
  • Fix some American/British English spelling inconsistencies.
  • Other minor fixes spotted along the way, including typo fixes with codespell.
  • Don't specify @GlobalScope for enum and constant.
    • This is debatable, we still seem to use it quite a lot for method, which makes sense to me. In this PR I just changed enum and constant because the predominant usage is without @GlobalScope, e.g. [enum Error] and [constant OK].

@akien-mga akien-mga added this to the 4.0 milestone Nov 1, 2022
@akien-mga akien-mga requested review from a team as code owners November 1, 2022 14:33
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted nothing besides the already mentioned things, LGTM.

@mhilbrunner
Copy link
Member

This is debatable, we still seem to use it quite a lot for method, which makes sense to me. In this PR I just changed enum and constant because the predominant usage is without @globalscope, e.g. [enum Error] and [constant OK].

Fine by me.

- Removed empty paragraphs in XML.
- Consistently use bold style for "Example:", on a new line.
- Fix usage of `[code]` when hyperlinks could be used (`[member]`, `[constant]`).
- Fix invalid usage of backticks for inline code in BBCode.
- Fix some American/British English spelling inconsistencies.
- Other minor fixes spotted along the way, including typo fixes with codespell.
- Don't specify `@GlobalScope` for `enum` and `constant`.
@akien-mga akien-mga merged commit efefd9b into godotengine:master Nov 2, 2022
@akien-mga akien-mga deleted the style-doc-cleanup branch November 2, 2022 21:39
@Mickeon Mickeon mentioned this pull request Nov 4, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants