Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore 'rotation_degrees' properties. #70263

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

reduz
Copy link
Member

@reduz reduz commented Dec 18, 2022

By popular demand, restoring the helper properties to rotate objects in degrees. Affected are local and global rotations for:

  • Node2D
  • Node3D
  • Control

Bugsquad edit:

@fire
Copy link
Member

fire commented Dec 18, 2022

I think we can assist with filling the documentation.

@TokisanGames
Copy link
Contributor

Fixes #63390

@kleonc kleonc linked an issue Dec 18, 2022 that may be closed by this pull request
@reduz reduz force-pushed the restore-rotation_degrees branch 2 times, most recently from fa1f214 to d9c7498 Compare December 19, 2022 09:09
By popular demand, restoring the helper properties to rotate objects in degrees.
Affected are local and global rotations for:

* Node2D
* Node3D
* Control
@reduz reduz force-pushed the restore-rotation_degrees branch from d9c7498 to 80b578b Compare December 19, 2022 09:59
@Mickeon
Copy link
Contributor

Mickeon commented Dec 19, 2022

There's a whole bit of mess now regarding rotation. What currently being exposed in the Inspector in Godot 4.0 is rotation in radians, with the "radians" hint_string, which allows it to be displayed in degrees, all the while showing an incorrect description when being hovered on...

@reduz
Copy link
Member Author

reduz commented Dec 19, 2022

@Mickeon This is fine, the main rotation is and will be in radians (even if editing can be done in degrees, because nobody edits those values in radians). The added functions are helpers and are documented as such.

@akien-mga akien-mga merged commit d124596 into godotengine:master Dec 19, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore rotation_degrees or provide deg_to_rad(Vector*)
6 participants