-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux/BSD] Include headers for dynamically loaded libraries to simplify build dependencies. #71263
Conversation
a7d391c
to
6941278
Compare
This is a good idea! I like it. |
I wonder if at this point |
Why isn't X11 in there? It's dynamically loaded now. Edit: note that if you try to regenerate the wrappers you'll stumble on a lot of issues, so I'd recommend not touching them for now. |
I think this is great! The only thing I'm unsure of is the whole license/copyright documentation situation. If we're vendoring the headers it definitely makes sense to include a license file next to the headers to make it clear what terms this specific code is under. But I don't see how using library headers from a vendored copy, or the ones provided on the build environment, would differ in practice - the same header code gets included in the Godot binary. So if we weren't documenting the license terms of all dlopen'ed libraries or system headers used by Godot code in It does make me doubt whether we should actually have been documenting these licenses all along, and that's something I'll try to get clarified with open source licensing experts. If we have to, I've basically never seen a project do this ever, whether open source or proprietary, so this would be an interesting situation. So for this PR I'd suggest:
As a side note, would be worth checking if we really needed to include the full set of headers or if we can get away with only a subset (i.e. the ones we include directly + their dependencies, if that's not the whole set). |
6941278
to
8184192
Compare
Added X11 headers, moved headers to |
…ify build dependencies.
8184192
to
5c4fe63
Compare
Thanks! |
Includes headers and licensing information for the libraries wrapped by https://github.com/hpvb/dynload-wrapper and dynamically loaded.
Fixes #67863 (and similar issues with build environment setup).