Revert Label text reshaping fix #71553 and subsequent regression fixes #73809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession fixes Despite a lot of great work from Pedro to try to improve the Label text reshaping logic and fix subsequent regressions, we found ourselves still chasing more edge cases, such as godotengine#73736 (which got reverted already due to it causing yet another regression). In parallel, it seems like the crash scenario that godotengine#71553 was addressing got solved differently in the master branch, so it appears like this change is no longer necessary at all (at least not urgently), so we decided to revert to the previous known "ok" state of Label. - Revert godotengine#71553 "Prevent infinite cascade of re-layout after label text reshaping" This reverts commit ed8c5cd. - Revert godotengine#72387 "Enhance label sizing algorithm" This reverts commit 5131b81. - Revert godotengine#73234 "Fix blank non-autowrapping labels" This reverts commit 3ccabee. - Revert godotengine#73343 "Make label sizing algorithm more robust" This reverts commit 4f7f1ef. - Revert godotengine#73426 "Fix width determination of non-trimmed, non-wrapped labels" This reverts commit 73b6c0b.
bruvzg
approved these changes
Feb 23, 2023
RandomShaper
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite a lot of great work from Pedro to try to improve the Label text reshaping logic and fix subsequent regressions, we found ourselves still chasing more edge cases, such as #73736 (which got reverted already due to it causing yet another regression).
In parallel, it seems like the crash scenario that #71553 was addressing got solved differently in the master branch, so it appears like this change is no longer necessary at all (at least not urgently), so we decided to revert to the previous known "ok" state of Label.
Revert Prevent infinite cascade of re-layout after label text reshaping #71553 "Prevent infinite cascade of re-layout after label text reshaping" This reverts commit ed8c5cd.
Revert Enhance label sizing algorithm (a.k.a. prevent infinite GUI re-layout) #72387 "Enhance label sizing algorithm" This reverts commit 5131b81.
Revert Fix blank non-autowrapping labels #73234 "Fix blank non-autowrapping labels" This reverts commit 3ccabee.
Revert Make label sizing algorithm more robust #73343 "Make label sizing algorithm more robust" This reverts commit 4f7f1ef.
Revert Fix width determination of non-trimmed, non-wrapped labels #73426 "Fix width determination of non-trimmed, non-wrapped labels" This reverts commit 73b6c0b.
This requires testing to make sure that all issues referenced in the above 5 PRs are still fixed.RandomShaper's edit:
Fixes #72950.
These are still fixed after this PR: