Fix Camera2D position smoothing properties not being grouped

[MarcusElg]

#65779 introduced a bug where Camera2D position smoothing properties aren't grouped due to the property names not matching the group name. This pr fixes that.

Before:

After:

EDIT: Also fixed the 3to4 project upgrader upgrading to invalid follow_smoothing property names

[kleonc]

Also it's inconsistent that position smoothing speed is shown even though position smoothing is disabled, whilst this isn't the case for rotation smoothing. However, that is a seperate issue and is related to godotengine/godot-proposals#4823

Actually the issue is in here:
https://github.com/godotengine/godot/blob/9ea7fb57bfba7828b026bf7d8bb92c999612a084/scene/2d/camera_2d.cpp#L702-L704
"smoothing_speed" should be changed to "position_smoothing_speed".

Also seems strange the internal variables are still named follow_smoothing_enabled, etc. Likely it was overlooked in #65779.

[MarcusElg]

Also it's inconsistent that position smoothing speed is shown even though position smoothing is disabled, whilst this isn't the case for rotation smoothing. However, that is a seperate issue and is related to godotengine/godot-proposals#4823

Actually the issue is in here:

https://github.com/godotengine/godot/blob/9ea7fb57bfba7828b026bf7d8bb92c999612a084/scene/2d/camera_2d.cpp#L702-L704

"smoothing_speed" should be changed to "position_smoothing_speed".
Also seems strange the internal variables are still named follow_smoothing_enabled, etc. Likely it was overlooked in #65779.

The internal variables can be renamed without breaking any compatibility right?

[kleonc]

The internal variables can be renamed without breaking any compatibility right?

private ones yeah. But follow_smoothing_enabled is protected so I wonder if theoretically it could be used from a module/GDExtension when extending Camera2D. But not sure about this. Also not sure about the policy regarding these, maybe they are not guaranteed to be unchanged, I don't know. Maybe @akien-mga could enlighten us a little on that. 🌞

[akien-mga]

GDExtension only has access to the same methods as GDScript (bound in _bind_methods).
As for C++ module compatibility, there's no guarantees. It's the price of having access to everything, module developers deal with our private/internal APIs. Compatibility is only aimed for the scripting API/bindings.

[MarcusElg]

I fixed the issues mentioned in the discussion, the internal properties has been renamed to match the exported names. However I noticed that the 3to4 project converter converts to old incorrect names such as "follow_smoothing_enabled". Should we change those as well?

[kleonc]

However I noticed that the 3to4 project converter converts to old incorrect names such as "follow_smoothing_enabled". Should we change those as well?

Yeah, as it's incorrect anyway. Currently it would rename smoothing_enabled to non existing follow_smoothing_enabled property (another overlooked thing in #65779).

godot/editor/renames_map_3_to_4.cpp

Line 1125 in 61d2c85

{ "smoothing_enabled", "follow_smoothing_enabled" }, // Camera2D

---

Note there are also some in C# renaming map:

godot/editor/renames_map_3_to_4.cpp

Line 724 in 61d2c85

{ "GetFollowSmoothing", "GetFollowSmoothingSpeed" }, // Camera2D

godot/editor/renames_map_3_to_4.cpp

Line 910 in 61d2c85

{ "SetEnableFollowSmoothing", "SetFollowSmoothingEnabled" }, // Camera2D

godot/editor/renames_map_3_to_4.cpp

Line 915 in 61d2c85

{ "SetFollowSmoothing", "SetFollowSmoothingSpeed" }, // Camera2D

godot/editor/renames_map_3_to_4.cpp

Lines 1218 to 1219 in 61d2c85

	{ "SmoothingEnabled", "FollowSmoothingEnabled" }, // Camera2D
	{ "SmoothingSpeed", "FollowSmoothingSpeed" }, // Camera2D

cc @raulsntos Just to be sure: all of these are also incorrect and the new names should have FollowSmoothing changed to PositionSmoothing, right?

[MarcusElg]

However I noticed that the 3to4 project converter converts to old incorrect names such as "follow_smoothing_enabled". Should we change those as well?

Yeah, as it's incorrect anyway. Currently it would rename smoothing_enabled to non existing follow_smoothing_enabled property (another overlooked thing in #65779).

godot/editor/renames_map_3_to_4.cpp

Line 1125 in 61d2c85

{ "smoothing_enabled", "follow_smoothing_enabled" }, // Camera2D

Note there are also some in C# renaming map:

godot/editor/renames_map_3_to_4.cpp

Line 724 in 61d2c85

{ "GetFollowSmoothing", "GetFollowSmoothingSpeed" }, // Camera2D

godot/editor/renames_map_3_to_4.cpp

Line 910 in 61d2c85

{ "SetEnableFollowSmoothing", "SetFollowSmoothingEnabled" }, // Camera2D

godot/editor/renames_map_3_to_4.cpp

Line 915 in 61d2c85

{ "SetFollowSmoothing", "SetFollowSmoothingSpeed" }, // Camera2D

godot/editor/renames_map_3_to_4.cpp

Lines 1218 to 1219 in 61d2c85

	{ "SmoothingEnabled", "FollowSmoothingEnabled" }, // Camera2D
	{ "SmoothingSpeed", "FollowSmoothingSpeed" }, // Camera2D

cc @raulsntos Just to be sure: all of these are also incorrect and the new names should have FollowSmoothing changed to PositionSmoothing, right?

Ok just as I expected, I've pushed a fix.

[raulsntos]

Just to be sure: all of these are also incorrect and the new names should have FollowSmoothing changed to PositionSmoothing, right?

Yes, but keep in mind that the methods are internal in 4.0 and the properties should be used instead. I don't think the project converter is able to do this kind of conversion but I also don't expect these methods to have a high usage since they were marked obsolete in 3.x.

[kleonc]

LGTM.

What @raulsntos mentioned regarding how C# methods which were changed to be internal in 4.0 are treated by the 3to4 converter seems like a potential seperate issue, out of scope of this PR.

[akien-mga]

Thanks!

[YuriSizov]

Cherry-picked for 4.0.1.