-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement inactive properties #74357
base: master
Are you sure you want to change the base?
Conversation
fa2ad77
to
1434a6a
Compare
@KoBeWi The issue with using a custom propertyhint as you suggested in the proposal is that it can only have one at the time, so as you see in the image above it looses it's suffix as well as min/max values etc. So maybe it's more logical to have it as a propertyusage instead? In that case there would have be a separate warning value for properties as propertyusages don't have any extra data. |
75711a2
to
0274306
Compare
I've changed it to be a propertyusage instead so now it's ready for some feedback |
0274306
to
776b072
Compare
Looks good overall, but I'm not convinced about adding another member to PropertyInfo (the |
776b072
to
6829f93
Compare
@KoBeWi have you discussed anything more regarding this? |
Not really. I forwarded this PR on RocketChat, you can join to discuss it (it would be faster than waiting for a comment in the PR). |
I think inactive properties should be colored gray, yellow clashes with properties of editable children (see #53260) |
An attempt to implement godotengine/godot-proposals#4823.
Currently an early draft to start the discussion. Imo some solution for dependent properties would improve the usability a lot, as it's currently a bit confusing what properties have an effect, and which don't. Currently it's implemented using a new PROPERTY_HINT that is changed in validate property, should a separate method like suggested in the proposal be used instead?
TODO:
Support translationDoneUse a custom theme colour for invalid propertiesDone