Expose Geometry2D.bresenham_line() method
#74714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could also update the InputEventMouseMotion description, which suggests "If you use InputEventMouseMotion to draw lines, consider implementing Bresenham's line algorithm as well to avoid visible gaps in lines if the user is moving the mouse quickly." |
dalexeev
force-pushed
the
expose-bresenham-line
branch
from
f5a33a8 to
658959d
Compare
dalexeev
force-pushed
the
expose-bresenham-line
branch
from
658959d to
d477098
Compare
timothyqiu
approved these changes
Oct 21, 2024
dalexeev
force-pushed
the
expose-bresenham-line
branch
from
d477098 to
08e8f5a
Compare
AThousandShips
approved these changes
Oct 21, 2024
Calinou
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Tested locally, it works as expected. Should be good to merge after applying the suggestion.
Testing project: test_pr_74714.zip
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
dalexeev
force-pushed
the
expose-bresenham-line
branch
from
08e8f5a to
9f0ae21
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method can be useful in user code.