Fix auto-translations in editor

[KoBeWi]

This PR enables auto-translation of Windows and Controls inside the editor, if they are not part of the edited scene.
Fixes #50650
Technically TTR() can now be retired in favor of TTRC(), probably.

I use get_viewport() != get_tree()->get_root() to determine whether a node is part of the scene tree, but this might yield some false-positives. A more reliable condition is

if (Engine::get_singleton()->is_editor_hint() && get_tree()->get_edited_scene_root() &&
		(get_tree()->get_edited_scene_root()->get_viewport() == get_viewport() || get_tree()->get_edited_scene_root()->get_viewport()->is_ancestor_of(get_viewport())))

and for Window

if (Engine::get_singleton()->is_editor_hint() && get_tree()->get_edited_scene_root() &&
		(get_tree()->get_edited_scene_root()->get_viewport() == get_parent_viewport() || get_tree()->get_edited_scene_root()->get_viewport()->is_ancestor_of(get_parent_viewport()))) {

but not sure if it's necessary 🤔

[YuriSizov]

I use get_viewport() != get_tree()->get_root() to determine whether a node is part of the scene tree, but this might yield some false-positives

Right. Wouldn't it also trigger in projects whenever you have multiple Window nodes or controls inside of windows, dialogs, or popups? I think a TOOLS_ENABLED injection should be okay here. We already have it in Controls at least. See get_parent_anchorable_rect, which relies on something similar for the editor only behavior.

[KoBeWi]

No this PR affects only the editor. False-positives is about nodes that are part of the editor, but get detected as scene nodes and don't not translated. It can happen if some node is not part of the main viewport.

[YuriSizov]

Ah, right, you guard with Engine::get_singleton()->is_editor_hint(). Well, since we already do TOOLS_ENABLED checks around the same code, we could also exclude this code at compile time. And then you would still reduce the chance of error if you check for the edited root's viewport, no?

[KoBeWi]

Ok added TOOLS_ENABLED check.
Also I switched to the complex condition, because buttons in dialogs are not under main viewport 🤦‍♂️ My only concern is the is_ancestor_of() check, but it's 100% accurate now at least.

[timothyqiu]

My only concern is the is_ancestor_of() check, but it's 100% accurate now at least.

Similar conditions are already used in several other nodes ;)

godot/scene/main/timer.cpp

Line 38 in ce90d77

if (Engine::get_singleton()->is_editor_hint() && get_tree()->get_edited_scene_root() && (get_tree()->get_edited_scene_root() == this || get_tree()->get_edited_scene_root()->is_ancestor_of(this))) {

godot/scene/gui/menu_bar.cpp

Line 252 in ce90d77

if (Engine::get_singleton()->is_editor_hint() && is_inside_tree() && get_tree()->get_edited_scene_root() && (get_tree()->get_edited_scene_root()->is_ancestor_of(this) || get_tree()->get_edited_scene_root() == this)) {

I think we can turn this logic into a method of Node.

[KoBeWi]

I added is_part_of_edited_scene() method and used it where applicable.

[YuriSizov]

Ah, such a beauty is gone now, packed inside of a neat new method.

[YuriSizov]

Thanks!