Fix NavigationObstacles not being added to avoidance simulation #75756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NavigationObstacles not being added to avoidance simulation.
YuriSizov
approved these changes
Apr 7, 2023
|
Thanks! |
|
Cherry-picked for 4.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NavigationObstacles not being added to avoidance simulation.
This fixes a regression from #74893 that fixed the bug that all agents would be added to the avoidance regardless.
The obstacles actually only worked while this bug was present as they never registered themself with the avoidance. Now that only "active" agents are added to the avoidance simulation the obstacles are ignored.
This fix with a dummy function for the callback is temporary as it is the least invasive fix for Godot 4.0.2. It will be removed with the avoidance rework again cause the rework does the entire avoidance enabling differently. Copying the same fix from the rework to 4.0.2 rightnow would require so many changes that it is not worth it.