Fix multiline items drawing in Tree
#76532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Apr 28, 2023
| @@ -1907,6 +1905,7 @@ void Tree::update_item_cell(TreeItem *p_item, int p_col) { | |||
| font_size = theme_cache.font_size; | |||
| } | |||
| p_item->cells.write[p_col].text_buf->add_string(valtext, font, font_size, p_item->cells[p_col].language); | |||
| p_item->cells.write[p_col].text_buf->set_break_flags(TextServer::BREAK_MANDATORY | TextServer::BREAK_WORD_BOUND | TextServer::BREAK_ADAPTIVE); | |||
There was a problem hiding this comment.
Wrap mode probably should be exposed as item property (similar to Label and other controls).
There was a problem hiding this comment.
I think this should be done as a separate PR, as AutowrapMode includes more than just LineBreakFlag.
There was a problem hiding this comment.
For the start LineBreakFlag would e.g. fix this here in editor.
More then one line makes it IMO unreadable, for more info we have the tooltip.
dalexeev
force-pushed
the
tree-fix-multiline-drawing
branch
from
309b3b0 to
865d6f5
Compare
|
I haven't been able to reproduce this in a test project, it only happens in the editor. I copied the editor theme to the project, but the error still doesn't appear. |
akien-mga
approved these changes
May 10, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76507.