-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement screen reader support using AccessKit library. #76829
base: master
Are you sure you want to change the base?
Conversation
7080b24
to
f964077
Compare
c547617
to
d350cf5
Compare
9195bad
to
c51daf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GDExtension and XR bits look fine to me!
(But given that those make up a vast minority of the changes here, I won't select "Approve" )
Now that this PR is in review, are there any parts that @bruvzg or the reviewer(s) want @DataTriny and me, the two main AccessKit developers, to review? |
Hi,
I am sorry to ask it here, hopefully I don't break any rules but is it possible that other parts of the editor such as tile map editor, canvas editor ETC become accessible?
… On 21 Mar 2025, at 5:05 PM, Matt Campbell ***@***.***> wrote:
mwcampbell
left a comment
(godotengine/godot#76829)
Now that this PR is in review, are there any parts that @bruvzg or the reviewer(s) want @DataTriny and me, the two main AccessKit developers, to review?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
<https://github.com/bruvzg> <https://github.com/DataTriny> <#76829 (comment)> <https://github.com/notifications/unsubscribe-auth/AN6B3G25M6DWY27CRUI5TOL2VQ2DZAVCNFSM6AAAAAAXZWZNAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBTHAYTIOBSGE>
mwcampbell
left a comment
(godotengine/godot#76829)
<#76829 (comment)>
Now that this PR is in review, are there any parts that @bruvzg <https://github.com/bruvzg> or the reviewer(s) want @DataTriny <https://github.com/DataTriny> and me, the two main AccessKit developers, to review?
—
Reply to this email directly, view it on GitHub <#76829 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN6B3G25M6DWY27CRUI5TOL2VQ2DZAVCNFSM6AAAAAAXZWZNAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBTHAYTIOBSGE>.
You are receiving this because you are subscribed to this thread.
|
I feel like that's probably out of scope for this initial PR, but FWIW I think this should still be possible by another way. Back when I worked with godot-accessibility, I experimented with a plugin that essentially replaced the tilemap editor with something a bit reminiscent of the old Sable tile editor. I didn't get far with it--just enough to learn that I could replace the widget and add in custom keyboard commands to edit the maps--so I don't have anything to show for it other than learning it was doable. Further discussion about this shouldn't continue here, and long-term it'd be nice to see actual accessibility on the tile editor, but in the meantime we should have a path forward. Making our own editor that manipulates the actual Godot tilemaps shouldn't be too hard. |
Initial implementation of the AccessKit integration use C-API:
All base (non-editor) controls should work now. UI behavior without active screen reader should be mostly unchanged. When screen reader is running, some controls that normally do not can accept keyboard focus (
Label
,RTL
,TabBar
) and extra keyboard actions (switching tabs, selecting RTL paragraph and embedded images/tables, selecting embeddedTreeItem
buttons).Only some editor UI parts are supported for now.
Additionally, provides access to some accessibility related OS settings (high contrast, reduce animation, reduce transparency and screen reader status)
Expects
accesskit_sdk_path
command line argument or environment variable with the path to the pre-build official accesskit-c folder (custom pre-builds for more platforms supported by Godot also available at https://github.com/godotengine/godot-accesskit-c-static/releases).Supersede #72886
Fixes #58074
Implements godotengine/godot-proposals#983 (partial)
Implements godotengine/godot-proposals#1964