Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention that the not operator cannot be used with Strings and StringNames #77227

Merged
merged 1 commit into from
May 30, 2023
Merged

Mention that the not operator cannot be used with Strings and StringNames #77227

merged 1 commit into from
May 30, 2023

Conversation

you-win
Copy link
Contributor

@you-win you-win commented May 19, 2023

Mention in the docs for String and StringName that the not operator cannot be used on Strings and StringNames.

Related resolved issue

@you-win you-win requested a review from a team as a code owner May 19, 2023 03:24
@dalexeev
Copy link
Member

@Chaosus Chaosus added this to the 4.1 milestone May 19, 2023
@mhilbrunner
Copy link
Member

@you-win Thanks for contributing. This looks good to me, but needs to be rebased to be merged.

@dalexeev
Copy link
Member

To me this is a bug/oversight that needs to be fixed (by #74741).

@mhilbrunner
Copy link
Member

mhilbrunner commented May 30, 2023 •
edited
Loading

Yeah, I agree. But until then documenting it doesn't hurt. :)

Edit: Pushed a rebase, fixed the conflict and applied Rémis capitalization change below to the commit message.

@akien-mga akien-mga changed the title mention that the not operator cannot be used with Strings and StringNames Mention that the not operator cannot be used with Strings and StringNames May 30, 2023
@mhilbrunner mhilbrunner force-pushed the docs/cannot-use-not-operator-for-strings branch from b8a7acc to 369239d Compare May 30, 2023 09:31
@mhilbrunner mhilbrunner force-pushed the docs/cannot-use-not-operator-for-strings branch from 369239d to 18fa7cf Compare May 30, 2023 09:33
@YuriSizov YuriSizov merged commit 7b6a065 into godotengine:master May 30, 2023
@YuriSizov
Copy link
Contributor

Thanks, and congrats on your first merged Godot PR!

@akien-mga akien-mga changed the title Mention that the not operator cannot be used with Strings and StringNames Mention that the not operator cannot be used with Strings and StringNames Jun 13, 2023
@iscke iscke mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@you-win @dalexeev @mhilbrunner @YuriSizov @Chaosus