Deprecate push_unhandled_input #77452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedworkDE
reviewed
May 24, 2023
|
Thanks, I wasn't aware of that flag. |
Sauermann
force-pushed
the
fix-deprecate-push-unhandled-input
branch
from
914705d to
e96b225
Compare
Sauermann
force-pushed
the
fix-deprecate-push-unhandled-input
branch
from
e96b225 to
18d51ad
Compare
RandomShaper
approved these changes
May 31, 2023
|
LGTM, AFAICT. TIWAGOS, though, |
YuriSizov
reviewed
May 31, 2023
YuriSizov
reviewed
May 31, 2023
Sauermann
force-pushed
the
fix-deprecate-push-unhandled-input
branch
from
18d51ad to
704495b
Compare
The functionality of `push_unhandled_input` has changed so that it no longer propagates input events to SubViewports. This makes it less predictable and it should be deprecated in favor of `push_input` which provides the same functionality and more. Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
Sauermann
force-pushed
the
fix-deprecate-push-unhandled-input
branch
from
704495b to
6d490ce
Compare
|
Thanks! |
|
Sorry for digging this up, but what if we don't want to propagate the input event to subviewports and embedded windows? I'm not sure there's an obvious way to do so without relying on the deprecated push_unhandled_input. |
|
@tangx246 yes, it is better to ask such usage questions in other places, since bugs should be discussed here, but you might want to look into the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality of
push_unhandled_inputhas changed so that it no longer propagates input events to SubViewports.This makes it less predictable and it should be deprecated in favor of
push_inputwhich provides the same functionality and more.Also this deprecation simplifies the Viewport-API by reducing the methods for pushing input events, so that users don't need to worry about when to use which function in order to insert input events.
Implement #76926 (comment)