-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make system information for issue reports single-line #77574
Make system information for issue reports single-line #77574
Conversation
I still foresee one issue which may defeat the purpose of making it a single line field again: the Godot version number in the system info (with hash) means that this field should basically be regenerated from Godot for each issue you make, so using a past entry would be inaccurate. I guess folks who want to use this convenience can manually remove the Godot version from their system info, since it's duplicated from the Godot version field in the issue template anyway. |
True .__.
One approach is better for bug reports on official builds. The other for testing custom builds… make two bug report templates? 😅
Am 29. Mai 2023 07:33:18 UTC schrieb "Rémi Verschelde" ***@***.***>:
…I still foresee one issue which may defeat the purpose of making it a single line field again: the Godot version number in the system info (with hash) means that this field should basically be regenerated from Godot for each issue you make, so using a past entry would be inaccurate.
I guess folks who want to use this convenience can manually remove the Godot version from their system info, since it's duplicated from the Godot version field in the issue template anyway.
--
Reply to this email directly or view it on GitHub:
#77574 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
@MJacred I think there can be only one on Github? |
If I understood the docs correctly, you can have multiple. Just put another file into .github/ISSUE_TEMPLATE folder
Am 29. Mai 2023 08:55:59 UTC schrieb Zireael07 ***@***.***>:
…
@MJacred I think there can be only one on Github?
--
Reply to this email directly or view it on GitHub:
#77574 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
There can be many issue templates, but there is not much practical reason to have a different one for custom builds. |
To make this easier we can put Godot version as the first item in the copied string. |
I'll do that tonight.
Am 29. Mai 2023 10:25:01 UTC schrieb Yuri Sizov ***@***.***>:
…> I guess folks who want to use this convenience can manually remove the Godot version from their system info, since it's duplicated from the Godot version field in the issue template anyway.
To make this easier we can put Godot version as the first item in the copied string.
--
Reply to this email directly or view it on GitHub:
#77574 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Additionally: * for custom builds, add commit hash * added a tooltip to help mitigate potential/understandable confusion whether the single-line output might be a bug * prettify driver name
bc19b5a
to
ca1ee31
Compare
@YuriSizov: Done |
Thanks! |
Context: Before #65902, the Bug Report Template had System Info as a single-line input field. Web browsers only cache values for auto-completion for input fields, not text areas.
Using auto-completion is especially useful for contributors who commit daily/weekly, whose system specs shouldn't change that often to warrant using the copy button in the editor every single time.
This PR
input
type again, andSee short exchange here: #65902 (comment)
@Calinou, @akien-mga: What do you think?
Editor
Output Format Now
Godot v4.1.dev (bc19b5abf) - Ubuntu 20.04.6 LTS (Focal Fossa) - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 970 (nvidia; 510.108.03) - Intel(R) Core(TM) i7-10700KF CPU @ 3.80GHz (16 Threads)
Output Format Before