Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix management of life cycle of volumetric fog related uniform sets #77703

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix management of life cycle of volumetric fog related uniform sets #77703

merged 1 commit into from
Jun 9, 2023

Conversation

RandomShaper
Copy link
Member

Fixes #77515.

@RandomShaper RandomShaper added this to the 4.1 milestone May 31, 2023
@RandomShaper RandomShaper requested a review from a team as a code owner May 31, 2023 17:57
@RandomShaper
Copy link
Member Author

RandomShaper commented May 31, 2023 •
edited
Loading

Just to elaborate, I assumed that the copy unform set's life cycle was bound to that of the three GI ones. It was wrong. I should have TIWAGOS.

@cridenour
Copy link
Contributor

Can confirm this fixes the MRP from #77680 and my original project issue that caused me to investigate.

Thanks for the quick fix!

@akien-mga akien-mga requested a review from clayjohn June 6, 2023 20:49
clayjohn
clayjohn approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@akien-mga akien-mga merged commit 7c71844 into godotengine:master Jun 9, 2023
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_vol_fog_thingy branch June 9, 2023 09:42
@akien-mga akien-mga changed the title Fix management of life cycle of vol. fog related uniform sets Fix management of life cycle of volumetric fog related uniform sets Jun 14, 2023
@bitsawer bitsawer mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug regression topic:rendering
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Changing between scenes that use volumetric fog causes unending error spam
4 participants
@RandomShaper @cridenour @akien-mga @clayjohn