Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with LOD selection when Camera is inside Meshes AABB #79589

Closed
wants to merge 1 commit into from
Closed

Conversation

0010200303
Copy link
Contributor

Fixed an issue where the LOD was selected only based of the Meshes AABB support points although the Camera being inside the AABB.

Fixed an issue where the LOD was selected only based of the Meshes AABB support points although the Camera being inside the AABB.
@0010200303 0010200303 requested a review from a team as a code owner July 17, 2023 17:47
@0010200303 0010200303 closed this Jul 17, 2023
@YuriSizov
Copy link
Contributor

@0010200303 Hey there! Did you intend to close this PR?

@0010200303
Copy link
Contributor Author

@YuriSizov Heyy thanks for checking. Yeah i intented to close this because it had a bad clang format and i didn't how to fix it so i just created a new one.

@YuriSizov
Copy link
Contributor

I see, #79590 supersedes this.

In future, you can just push to the same branch, including force-pushing and rewriting entire history, to update your PR. I also recommend not using your master branch and creating a feature branch from it, so resolving these issues is easier in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants