Fix a crash when Sprite3D.extra_cull_margin is positive and then assign a texture to it
#81069
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjtxietian
force-pushed
the
fix-crash-when-Sprite3D.extra_cull_margin-positive-then-assign
branch
from
54d0bdc to
574e053
Compare
jsjtxietian
force-pushed
the
fix-crash-when-Sprite3D.extra_cull_margin-positive-then-assign
branch
from
574e053 to
75c85a3
Compare
jsjtxietian
force-pushed
the
fix-crash-when-Sprite3D.extra_cull_margin-positive-then-assign
branch
from
75c85a3 to
129f85c
Compare
akien-mga
changed the title
Sprite3D.extra_cull_margin is positive and then assign a texture to it
|
I haven't update this pr for a long time, probably need some re-thinking on the fix now ( back then I had little experience of Godot ). |
This was referenced Aug 13, 2024
|
Superseded by #95503 |
jsjtxietian
deleted the
fix-crash-when-Sprite3D.extra_cull_margin-positive-then-assign
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes #80749.
It works in my test but I'm no familiar with the code logic so I'm not sure whether this change will break other things.
The bug's root cause can be found in the issue conversation. Basically what I do is to rebuild the bvh when p_instance's base_type change from
INSTANCE_NONEto anyINSTANCE_GEOMETRY. Maybe there is a better way to fix this issue, thank you for your suggestions in advance.