Fix TextEdit/CodeEdit crash with invalid caret position. #81331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paulb23
reviewed
Sep 10, 2023
akien-mga
reviewed
Oct 26, 2023
| @@ -623,7 +623,7 @@ void TextEdit::_notification(int p_what) { | |||
| } | |||
| } | |||
|
|
|||
| if (get_caret_column(caret) > 0) { | |||
| if (get_caret_column(caret) > 0 && get_caret_column(caret) <= text[get_caret_line(caret)].length()) { | |||
There was a problem hiding this comment.
If @Paulb23 doesn't like that approach, maybe we can make this an ERR_FAIL_COND instead, so it still fixes the crash but points that there's something fishy?
akien-mga
added
the
cherrypick:4.2
|
Superseded by #86978. |
akien-mga
added
archived
and removed
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73202