Add is_valid_letter() to TextServer
#81639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MJacred
force-pushed
the
is_letter
branch
2 times, most recently
from
d903546 to
6eb4d86
Compare
|
The code works, but the list of ranges is not complete. I used https://www.unicode.org/Public/UCD/latest/ucd/PropList.txt, but it's only a subset. https://unicode.org/Public/UNIDATA/DerivedCoreProperties.txt seems to be the correct file for this… |
MJacred
force-pushed
the
is_letter
branch
2 times, most recently
from
65101e8 to
e293f71
Compare
|
I'm auto-creating these ranges using a little program I wrote. What it currently doesn't do: further range merging, if the unicode values inbetween are unprintable/undefined, e.g. 0x1ee8a. |
MJacred
changed the title
adamscott
changed the title
is_valid_letter() to TextServer
|
@adamscott: ping! you wanted to review this PR? |
|
@adamscott: reminder of this PR |
bruvzg
approved these changes
May 2, 2024
AThousandShips
approved these changes
May 2, 2024
MJacred
force-pushed
the
is_letter
branch
2 times, most recently
from
c91e55f to
6edee45
Compare
MJacred
force-pushed
the
is_letter
branch
2 times, most recently
from
ab54e3d to
0ea6ac2
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes godotengine/godot-proposals#7656
Test project:
letter_test.tar.gz
related PR:
String.to_*_case()methods #75846