Add half-pixel offset to lightmapper rasterization. #81872
Merged
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add half-pixel offset to lightmapper to fix issues where the ray would be generated from the wrong spot corresponding to the pixel and causing light leaks. Fixes Issue godotengine#69126.
|
Might also help with #63437 in case someone wants to test it. |
Testing project: test_lightmap_preview_bake_4.x_1.zip
Testing project: test_lightmap_one_sided.zip |
clayjohn
approved these changes
Sep 20, 2023
|
Thanks! |
|
Cherry-picked for 4.1.2. |
This was referenced Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add half-pixel offset to lightmapper to fix issues where the ray would be generated from the wrong spot corresponding to the pixel and causing light leaks. Fixes Issue #69126.
As said in the issue and code comments, this is required so the lightmapper doesn't spawn rays from the very edge of the faces. It looks a bit hacky at first but there's a pretty solid reason behind it and as far as I can tell it fixes leaks in most scenarios I could find. Basically, by using this offset, the interpolated position the pixel shader receives will never be perfectly aligned at the edges of the faces but right on the middle of the pixel, which is what is usually desired.
Denoiser is recommended to be off when testing, as the current denoiser can cause light leaking on its own that doesn't exist in the noisy output due to the blurring.
Before
After
Before
After
(Lighting differences might be due to exposure adjustment or just less light leaking into the scene, but it's to be expected)
Testing out the fix in more scenes would be appreciated.
Bugsquad edit: