Implement fit content width in TextEdit #83070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it working with line wrapping enabled? |
|
@bruvzg Yes. When wrap mode is set to Boundary it wraps instead of getting wider, behaving the same as if this setting is disabled. Note that these settings are intended to be mutually exclusive, having both enabled is not useful. |
aaronfranke
force-pushed
the
textedit-fit-width
branch
from
8220acc to
5fd8bf2
Compare
aaronfranke
force-pushed
the
textedit-fit-width
branch
from
5fd8bf2 to
fe71e5c
Compare
aaronfranke
force-pushed
the
textedit-fit-width
branch
from
fe71e5c to
063bc3f
Compare
aaronfranke
force-pushed
the
textedit-fit-width
branch
from
063bc3f to
eb67128
Compare
aaronfranke
force-pushed
the
textedit-fit-width
branch
from
eb67128 to
60007a2
Compare
aaronfranke
force-pushed
the
textedit-fit-width
branch
from
60007a2 to
7697e6a
Compare
kitbdev
reviewed
Mar 17, 2024
aaronfranke
force-pushed
the
textedit-fit-width
branch
from
4705038 to
df7b31d
Compare
aaronfranke
force-pushed
the
textedit-fit-width
branch
from
df7b31d to
3c77965
Compare
aaronfranke
force-pushed
the
textedit-fit-width
branch
from
3c77965 to
e8bd861
Compare
Paulb23
approved these changes
Jul 30, 2024
aaronfranke
force-pushed
the
textedit-fit-width
branch
from
e8bd861 to
e548535
Compare
AThousandShips
approved these changes
Aug 4, 2024
Co-authored-by: Kit Bishop <kitbdev@gmail.com>
aaronfranke
force-pushed
the
textedit-fit-width
branch
from
e548535 to
3b8afcd
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextEdit already has
scroll_fit_content_height, but there is no equivalent for width. This PR addsscroll_fit_content_widthwith the same behavior for width. When both are enabled, there are no scrollbars. I have tested that this works correctly in The Mirror and in a minimal project.