Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix android wrapper comments #85141

Closed
wants to merge 1 commit into from
Closed

Fix android wrapper comments #85141

wants to merge 1 commit into from

Conversation

Alex2782
Copy link
Member

Only two comments adjusted, new files:

@Alex2782 Alex2782 requested a review from a team as a code owner November 20, 2023 16:20
@AThousandShips AThousandShips added this to the 4.x milestone Nov 20, 2023
m4gr3d
m4gr3d approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@m4gr3d m4gr3d modified the milestones: 4.x, 4.3 Nov 20, 2023
@Alex2782
Copy link
Member Author

I'm not sure about GodotRenderView.java, only Vulkan and GL?

image

@m4gr3d
Copy link
Contributor

m4gr3d commented Nov 20, 2023

I'm not sure about GodotRenderView.java, only Vulkan and GL?

image

What do you mean?

GodotRenderView is the interface that defines the set of methods we expect from our view implementation of which we have 1 for OpenGL and 1 for Vulkan.

@Alex2782
Copy link
Member Author

ok 👍

@akien-mga
Copy link
Member

Thanks for the fix! I merged this together with a few other recent PRs fixing other comments, to avoid merging 4 PRs for 4 typos :)

Superseded by fa259a7.

@akien-mga akien-mga closed this Nov 21, 2023
@akien-mga akien-mga modified the milestones: 4.3, 4.2 Nov 21, 2023
@AThousandShips AThousandShips removed this from the 4.2 milestone Nov 21, 2023
@Alex2782 Alex2782 deleted the wrapper_comments branch November 21, 2023 21:49
@cmumme cmumme mentioned this pull request Dec 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
archived enhancement topic:codestyle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alex2782 @m4gr3d @akien-mga @AThousandShips