Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement FFI for GDScript. #85741

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -380,3 +380,4 @@ $RECYCLE.BIN/
*.msp
*.lnk
*.generated.props
*.obj.i
5 changes: 5 additions & 0 deletions COPYRIGHT.txt
Original file line number Diff line number Diff line change
@@ -304,6 +304,11 @@ Comment: libbacktrace
Copyright: 2012-2021, Free Software Foundation, Inc.
License: BSD-3-clause

Files: ./thirdparty/libffi/
Comment: libffi
Copyright: 1996-2022 Anthony Green, Red Hat, Inc and others.
License: Expat

Files: ./thirdparty/libktx/
Comment: KTX
Copyright: 2013-2020, Mark Callow
1 change: 1 addition & 0 deletions SConstruct
Original file line number Diff line number Diff line change
@@ -279,6 +279,7 @@ opts.Add(BoolVariable("builtin_certs", "Use the built-in SSL certificates bundle
opts.Add(BoolVariable("builtin_clipper2", "Use the built-in Clipper2 library", True))
opts.Add(BoolVariable("builtin_embree", "Use the built-in Embree library", True))
opts.Add(BoolVariable("builtin_enet", "Use the built-in ENet library", True))
opts.Add(BoolVariable("builtin_libffi", "Use the built-in FFI library", True))
opts.Add(BoolVariable("builtin_freetype", "Use the built-in FreeType library", True))
opts.Add(BoolVariable("builtin_msdfgen", "Use the built-in MSDFgen library", True))
opts.Add(BoolVariable("builtin_glslang", "Use the built-in glslang library", True))
12 changes: 12 additions & 0 deletions core/variant/variant_call.cpp
Original file line number Diff line number Diff line change
@@ -674,6 +674,15 @@ struct _VariantCall {
VARCALL_PACKED_GETTER(PackedVector3Array, Vector3)
VARCALL_PACKED_GETTER(PackedVector4Array, Vector4)

static uint64_t func_PackedByteArray_unsafe_get_ptr(PackedByteArray *p_instance) {
return (uint64_t)(void *)(p_instance->ptrw());
}

static void func_PackedByteArray_unsafe_from_ptr(PackedByteArray *p_instance, uint64_t p_ptr, uint64_t p_size) {
p_instance->resize(p_size);
memcpy(p_instance->ptrw(), (void *)p_ptr, p_size);
}

static String func_PackedByteArray_get_string_from_ascii(PackedByteArray *p_instance) {
String s;
if (p_instance->size() > 0) {
@@ -2431,6 +2440,9 @@ static void _register_variant_builtin_methods_array() {
bind_function(PackedByteArray, decompress, _VariantCall::func_PackedByteArray_decompress, sarray("buffer_size", "compression_mode"), varray(0));
bind_function(PackedByteArray, decompress_dynamic, _VariantCall::func_PackedByteArray_decompress_dynamic, sarray("max_output_size", "compression_mode"), varray(0));

bind_functionnc(PackedByteArray, unsafe_get_ptr, _VariantCall::func_PackedByteArray_unsafe_get_ptr, sarray(), varray());
bind_functionnc(PackedByteArray, unsafe_from_ptr, _VariantCall::func_PackedByteArray_unsafe_from_ptr, sarray("ptr", "size"), varray());

bind_function(PackedByteArray, decode_u8, _VariantCall::func_PackedByteArray_decode_u8, sarray("byte_offset"), varray());
bind_function(PackedByteArray, decode_s8, _VariantCall::func_PackedByteArray_decode_s8, sarray("byte_offset"), varray());
bind_function(PackedByteArray, decode_u16, _VariantCall::func_PackedByteArray_decode_u16, sarray("byte_offset"), varray());
14 changes: 14 additions & 0 deletions doc/classes/PackedByteArray.xml
Original file line number Diff line number Diff line change
@@ -486,6 +486,20 @@
If the original data can't be converted to signed 64-bit integers, the resulting data is undefined.
</description>
</method>
<method name="unsafe_from_ptr">
<return type="void" />
<param index="0" name="ptr" type="int" />
<param index="1" name="size" type="int" />
<description>
Resizes array and copies data for the unsafe pointer.
</description>
</method>
<method name="unsafe_get_ptr">
<return type="int" />
<description>
Returns unsafe raw pointer to the array data.
</description>
</method>
</methods>
<operators>
<operator name="operator !=">
238 changes: 238 additions & 0 deletions modules/ffi/SCsub
Original file line number Diff line number Diff line change
@@ -0,0 +1,238 @@
#!/usr/bin/env python

Import("env")
Import("env_modules")

import subprocess
from SCons.Defaults import _defines, _concat

env_ffi = env_modules.Clone()

# Thirdparty source files

thirdparty_obj = []


def mscv_preprocess_and_assemble_file_x86(target, source, env):
for x in range(len(source)):
try:
defs = _defines(env["CPPDEFPREFIX"], env["CPPDEFINES"], env["CPPDEFSUFFIX"], env, target, source)
incs = _concat(env["INCPREFIX"], env["CPPPATH"], env["INCSUFFIX"], env)

cmd = str(env["CC"]) + " /FA /P /EP /nologo"
for d in defs:
cmd += " " + d
for i in incs:
cmd += " " + i.replace("#", "./")
cmd += " " + str(source[x]) + " /Fi" + str(target[x]) + ".i"
subprocess.Popen(cmd, shell=True, stderr=subprocess.PIPE).communicate()

cmd = str(env["AS"])
for i in incs:
cmd += " " + i.replace("#", "./")
cmd += " /Fo" + str(target[x]) + " /c " + str(target[x]) + ".i"
subprocess.Popen(cmd, shell=True, stderr=subprocess.PIPE).communicate()
except Exception:
return -1

return 0


def mscv_preprocess_and_assemble_file_arm(target, source, env):
for x in range(len(source)):
defs = _defines(env["CPPDEFPREFIX"], env["CPPDEFINES"], env["CPPDEFSUFFIX"], env, target, source)
incs = _concat(env["INCPREFIX"], env["CPPPATH"], env["INCSUFFIX"], env)

cmd = str(env["CC"]) + " /FA /P /EP /nologo"
for d in defs:
cmd += " " + d
for i in incs:
cmd += " " + i.replace("#", "./")
cmd += " " + str(source[x]) + " /Fi" + str(target[x]) + ".i"
subprocess.Popen(cmd, shell=True, stderr=subprocess.PIPE).communicate()

cmd = str(env["AS"])
cmd += " " + str(target[x]) + ".i" + " -o " + str(target[x])
subprocess.Popen(cmd, shell=True, stderr=subprocess.PIPE).communicate()

return 0


if env["builtin_libffi"]:
thirdparty_dir = "#thirdparty/libffi/"
thirdparty_sources = [
"src/closures.c",
"src/prep_cif.c",
"src/types.c",
"src/tramp.c",
]

env_ffi.Prepend(CPPPATH=[thirdparty_dir + "include/"])
env_ffi.Prepend(CPPPATH=[thirdparty_dir + "src/"])
env_ffi.Append(CPPDEFINES=["FFI_STATIC_BUILD"])

if env["platform"] == "web":
env_ffi.Prepend(CPPPATH=[thirdparty_dir + "src/wasm32/"])
thirdparty_sources += ["src/wasm32/ffi.c"]
elif env["arch"] == "arm64":
env_ffi.Prepend(CPPPATH=[thirdparty_dir + "src/aarch64/"])
thirdparty_sources += ["src/aarch64/ffi.c"]
if env["platform"] == "windows":
if env.msvc:
env_ffi_asm = env_ffi.Clone()
env_ffi_asm["AS"] = "armasm64"
env_ffi_asm.Append(CPPDEFINES=["_M_ARM64", "_MSC_VER"])
env_ffi_asm.Append(
BUILDERS={
"ASPP": env.Builder(action=mscv_preprocess_and_assemble_file_arm, suffix=".o", src_suffix=".S")
}
)
env.modules_sources += env_ffi_asm.ASPP(
thirdparty_dir + "src/aarch64/win64_armasm" + env["OBJSUFFIX"],
thirdparty_dir + "src/aarch64/win64_armasm.S",
)
else:
env_ffi["AS"] = env["CC"]
env_ffi["ASFLAGS"] += [
"-c",
"-Ithirdparty/libffi/src/aarch64/",
"-Ithirdparty/libffi/src/",
"-Ithirdparty/libffi/include/",
]
thirdparty_sources += ["src/aarch64/win64_armasm.S"]
else:
if env["platform"] == "macos" or env["platform"] == "ios":
env_ffi.Append(CPPDEFINES=["FFI_EXEC_TRAMPOLINE_TABLE"])
thirdparty_sources += ["src/aarch64/sysv.S"]
elif env["arch"] == "arm32":
env_ffi.Prepend(CPPPATH=[thirdparty_dir + "src/arm/"])
thirdparty_sources += ["src/arm/ffi.c"]
if env["platform"] == "windows":
if env.msvc:
env_ffi_asm = env_ffi.Clone()
env_ffi_asm["AS"] = "armasm"
env_ffi_asm.Append(CPPDEFINES=["_M_ARM", "_MSC_VER"])
env_ffi_asm.Append(
BUILDERS={
"ASPP": env.Builder(action=mscv_preprocess_and_assemble_file_arm, suffix=".o", src_suffix=".S")
}
)
env.modules_sources += env_ffi_asm.ASPP(
thirdparty_dir + "src/arm/sysv_msvc_arm32" + env["OBJSUFFIX"],
thirdparty_dir + "src/arm/sysv_msvc_arm32.S",
)
else:
env_ffi["AS"] = env["CC"]
env_ffi["ASFLAGS"] += [
"-c",
"-Ithirdparty/libffi/src/arm/",
"-Ithirdparty/libffi/src/",
"-Ithirdparty/libffi/include/",
]
thirdparty_sources += ["src/arm/sysv_msvc_arm32.S"]
else:
thirdparty_sources += ["src/arm/sysv.S"]
elif env["arch"] == "x86_64":
env_ffi.Prepend(CPPPATH=[thirdparty_dir + "src/x86/"])
if env["platform"] == "windows":
env_ffi.Append(CPPDEFINES=["X86_WIN64"])
else:
if env["platform"] == "macos" or env["platform"] == "ios":
env_ffi.Append(CPPDEFINES=["X86_DARWIN"])
else:
env_ffi.Append(CPPDEFINES=["X86_64"])
thirdparty_sources += ["src/x86/ffi64.c"]
thirdparty_sources += ["src/x86/unix64.S"]
thirdparty_sources += ["src/x86/ffiw64.c"]
if env.msvc:
env_ffi_asm = env_ffi.Clone()
env_ffi_asm["AS"] = "ml64"
env_ffi_asm.Append(CPPDEFINES=["__x86_64__", "_MSC_VER"])
env_ffi_asm.Append(
BUILDERS={
"ASPP": env.Builder(action=mscv_preprocess_and_assemble_file_x86, suffix=".o", src_suffix=".S")
}
)
env.modules_sources += env_ffi_asm.ASPP(
thirdparty_dir + "src/x86/win64" + env["OBJSUFFIX"], thirdparty_dir + "src/x86/win64_intel.S"
)
else:
env_ffi.Append(CPPDEFINES=["HAVE_AS_X86_PCREL"])
env_ffi["AS"] = env["CC"]
env_ffi["ASFLAGS"] += [
"-c",
"-Ithirdparty/libffi/src/x86/",
"-Ithirdparty/libffi/src/",
"-Ithirdparty/libffi/include/",
]
thirdparty_sources += ["src/x86/win64.S"]
elif env["arch"] == "x86_32":
env_ffi.Prepend(CPPPATH=[thirdparty_dir + "src/x86/"])
env_ffi.Append(CPPDEFINES=[("EH_FRAME_FLAGS", '\\"a\\"')])
if env["platform"] == "windows":
env_ffi.Append(CPPDEFINES=["X86_WIN32"])
thirdparty_sources += ["src/x86/ffi.c"]
if env.msvc:
env_ffi_asm = env_ffi.Clone()
env_ffi_asm["AS"] = "ml"
env_ffi_asm.Append(CPPDEFINES=["__i386__", "_MSC_VER"])
env_ffi_asm.Append(
BUILDERS={
"ASPP": env.Builder(action=mscv_preprocess_and_assemble_file_x86, suffix=".o", src_suffix=".S")
}
)
env.modules_sources += env_ffi_asm.ASPP(
thirdparty_dir + "src/x86/sysv" + env["OBJSUFFIX"], thirdparty_dir + "src/x86/sysv_intel.S"
)
else:
env_ffi.Append(CPPDEFINES=["HAVE_AS_X86_PCREL"])
env_ffi["AS"] = env["CC"]
env_ffi["ASFLAGS"] += [
"-c",
"-Ithirdparty/libffi/src/x86/",
"-Ithirdparty/libffi/src/",
"-Ithirdparty/libffi/include/",
]
thirdparty_sources += ["src/x86/sysv.S"]
elif env["arch"] == "rv64":
env_ffi.Prepend(CPPPATH=[thirdparty_dir + "src/riscv/"])
thirdparty_sources += ["src/riscv/ffi.c"]
env_ffi["AS"] = env["CC"]
env_ffi["ASFLAGS"] += [
"-c",
"-Ithirdparty/libffi/src/riscv/",
"-Ithirdparty/libffi/src/",
"-Ithirdparty/libffi/include/",
]
thirdparty_sources += ["src/riscv/sysv.S"]
elif env["arch"] == "ppc32" or env["arch"] == "ppc64":
env_ffi.Prepend(CPPPATH=[thirdparty_dir + "src/powerpc/"])
thirdparty_sources += ["src/powerpc/ffi.c"]
thirdparty_sources += ["src/powerpc/ffi_sysv.c"]
thirdparty_sources += ["src/powerpc/ffi_linux64.c"]
env_ffi["AS"] = env["CC"]
env_ffi["ASFLAGS"] += [
"-c",
"-Ithirdparty/libffi/src/powerpc/",
"-Ithirdparty/libffi/src/",
"-Ithirdparty/libffi/include/",
]
thirdparty_sources += ["src/powerpc/sysv.S"]
thirdparty_sources += ["src/powerpc/linux64.S"]

thirdparty_sources = [thirdparty_dir + file for file in thirdparty_sources]

env_thirdparty = env_ffi.Clone()
env_thirdparty.disable_warnings()
env_thirdparty.add_source_files(thirdparty_obj, thirdparty_sources)
env.modules_sources += thirdparty_obj

# Godot source files

module_obj = []

env_ffi.add_source_files(module_obj, "*.cpp")
env.modules_sources += module_obj

# Needed to force rebuilding the module files when the thirdparty library is updated.
env.Depends(module_obj, thirdparty_obj)
16 changes: 16 additions & 0 deletions modules/ffi/config.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
def can_build(env, platform):
return True


def configure(env):
pass


def get_doc_classes():
return [
"FFILibrary",
]


def get_doc_path():
return "doc_classes"
Loading