Cleanup in undo in TextEdit
and LineEdit
#86085
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both
TextEdit
andLineEdit
, the Undo and Redo functions seemed to check for themselves whether there was an Undo/Redo available rather than using the existinghas_undo
orhas_redo
functions. I decided to make them use them to remove repetition.Only exception was the
TextEdit
Undo
function. I noticed its check for an Undo was slightly different from thehas_undo
function. I decided to leave it alone.