Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading less common DDS formats #86204

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

BlueCube3310
Copy link
Contributor

@BlueCube3310 BlueCube3310 commented Dec 15, 2023

Follow-up to #81220

Implements support for loading some less common DDS formats, such as:

  • A8,
  • DXT2,
  • DXT4,
  • B2GR3,
  • B2GR3A8,
  • LA4,
  • RGB32F,
  • SRGB variants of RGBA8, BC1, BC2, BC3 and BC7

Also changes the loader to now require the DDPF_LUMINANCE flag for grayscale formats, though there is a chance this may break files created by writers which don't set it.

I've marked it as draft in case there are more unsupported formats.

MRP for testing the changes: DDSFormatsUncommon.zip

@AThousandShips AThousandShips added this to the 4.x milestone Dec 15, 2023
@BlueCube3310 BlueCube3310 force-pushed the dds-more-formats branch 2 times, most recently from e909a65 to e77e09d Compare December 16, 2023 11:25
@BlueCube3310 BlueCube3310 force-pushed the dds-more-formats branch 2 times, most recently from 883c076 to 47b4f3c Compare January 5, 2024 13:51
@BlueCube3310 BlueCube3310 marked this pull request as ready for review January 5, 2024 14:00
@BlueCube3310 BlueCube3310 requested a review from a team as a code owner January 5, 2024 14:00
@BlueCube3310 BlueCube3310 marked this pull request as draft February 13, 2024 23:29
@BlueCube3310 BlueCube3310 force-pushed the dds-more-formats branch 2 times, most recently from 5168aa6 to ac5efe0 Compare March 17, 2024 17:27
@BlueCube3310 BlueCube3310 marked this pull request as ready for review March 17, 2024 17:29
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we say we support DDS, it makes sense that we should support all dds formats.

I don't have production samples to test. There is a test sample. Did not technical review.

@clayjohn clayjohn modified the milestones: 4.x, 4.4 Jul 24, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I didn't test locally, but I trust that bluecube3310 has done a good job testing

@akien-mga akien-mga merged commit 205443d into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants