Update doc to mention that visual comment node is currently not visible #86890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
enhancement
documentation
cherrypick:4.2
|
Comment nodes were removed completely and unfortunately won't be restored. |
AThousandShips
added
the
cherrypick:4.3
|
I feel like this is not necessary anymore, even for 4.2, as the original issues have been closed. So I'm closing this PR, but thank you for your contribution. If you feel like this is still necessary for a potential 4.2 version, open a PR targeting the 4.2 branch with a different note, as the current one is not exactly fitting now. |
Mickeon
added
archived
and removed
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #86883
It looks like many users are won't aware of the rework and due to the fact that the replacement is not ready yet, IMO we can at least update the doc now as suggested in #79307 (comment)
The doc itself maybe not needed in 4.3 as the rework might be ready in 4.3, but can be cherry picked for 4.2 at least now.