-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add way to check if a signal has any connections #87344
Conversation
Unsure about |
I'd prefer the name to be uniform on both, but I think there's no difference in reading |
I think |
I'd say that both could be seen that way, but I'll change the naming from the consensus, I've got no strong feelings either way |
a6b3ce6
to
f7a58e6
Compare
Might go with |
Suggestion: Change current function Now you can also give the function for more elegant naming |
No changing existing function names, it would break compatibility. |
f7a58e6
to
096e79c
Compare
096e79c
to
2bc83e9
Compare
2bc83e9
to
86158a9
Compare
86158a9
to
d01d760
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation is completely fine.
d01d760
to
31e4f71
Compare
31e4f71
to
a8d98f7
Compare
a8d98f7
to
83a1b39
Compare
Added to `Object` and `Signal`
83a1b39
to
203d3be
Compare
Thanks! |
Thank you! |
Added to
Object
andSignal
Went withany_connected
because it felt clear and direct as a description, could usehas_connections
too if desiredWill see about adding some unit tests for this but we don't have unit tests for
is_connected
so unsure how to approach thatUnsure if I need to do anything special on the C# side, looked at the
Signal
class and didn't see anything to add