-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export EditorInspector::instantiate_property_editor
for use by plugins
#87375
Merged
Repiteo
merged 1 commit into
godotengine:master
from
limbonaut:instantiate_property_editor
Dec 9, 2024
Merged
Export EditorInspector::instantiate_property_editor
for use by plugins
#87375
Repiteo
merged 1 commit into
godotengine:master
from
limbonaut:instantiate_property_editor
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll update it, and make a demo. |
648fd26
to
5e2bc4c
Compare
5e2bc4c
to
c19510b
Compare
c19510b
to
fa6135e
Compare
PR updated & rebased. |
nonchip
approved these changes
May 13, 2024
10 tasks
reduz
approved these changes
Oct 7, 2024
KoBeWi
approved these changes
Dec 7, 2024
AThousandShips
approved these changes
Dec 7, 2024
And export useful properties and methods in the `EditorProperty` class.
fa6135e
to
803fa8f
Compare
EditorInspector::instantiate_property_editor
to use by pluginsEditorInspector::instantiate_property_editor
for use by plugins
Thanks! Congratulations on your first merged contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exports
EditorInspector::instantiate_property_editor
in the Godot API, so that plugin developers could reuse existing property editors in their projects. It also exports several useful properties and methods in theEditorProperty
. Some of those properties are needed to implement custom inspectors (demo below).See proposal: closes godotengine/godot-proposals#8908
With this change, users can create a property editor like this:
Test/demo project: Plugin that adds a custom inspector for a data object in the bottom panel: https://github.com/limbonaut/godot-custom-inspector-demo