Prevent some internal nodes being duplicated in Controls

[AThousandShips]

Caused by duplication of on-demand created children, for example:

var cpb := ColorPickerButton.new()
print(cpb.get_child_count(true))
print(cpb.get_popup())
print(cpb.get_child_count(true))

var cpb2 := cpb.duplicate()
print(cpb2.get_child_count(true))
print(cpb2.get_popup())
print(cpb2.get_child_count(true))

Will print:

0
@PopupPanel@...:<PopupPanel#...>
1
1
@PopupPanel@...:<PopupPanel#...>
2

This fixes these

There are probably some other potential cases but unsure how to apply each, but keeping these specific menu cases for now

[KoBeWi]

I think #84824 fixes the same issue, no?

[AThousandShips]

It does not, I tried it with at least some cases, will confirm but that is for instanced nodes I believe

Edit: It does not solve this issue

[Rindbee]

#84824 solves the case when copying sub-scenes. The case here is the case of internal nodes in the same scene.

Internal nodes are usually added when the parent node is initialized or under certain conditions. They can be treated as part of the parent node.

godot/scene/main/node.cpp

Lines 2599 to 2607 in 94dbf69

	for (int i = 0; i < get_child_count(); i++) {
	if (get_child(i)->data.parent_owned) {
	continue;
	}
	if (instantiated && get_child(i)->data.owner == this) {
	continue; //part of instance
	}
	Node *dup = get_child(i)->_duplicate(p_flags, r_duplimap);

-       for (int i = 0; i < get_child_count(); i++) {
+       for (int i = 0; i < get_child_count(false); i++) {

It may be better to directly exclude internal nodes when copying.

[AThousandShips]

Some internal nodes might not be automatically added though and might be data independent, unsure, but it'd also break compat to change it for internal nodes IMO as scripts may use it

Note that if they're added in the constructor they are already automatically excluded

[Rindbee]

Well, you are right, the script can manage the entire tree, possibly adding additional cases.

See #89442

[AThousandShips]

This is still relevant for 4.2 and would be best to get in first IMO, #89442 isn't necessarily cherry-pickable, but I can always retarget it for 4.2

[AThousandShips]

Haven't looked for any new cases of this since this was opened, there might be some cases will try and search for them

Edit: Seems at least all relevant cases of internal nodes being handled

[akien-mga]

Haven't looked for any new cases of this since this was opened, there might be some cases will try and search for them

There's at least #92880 which would be fixed by #89442, unless the internal node in GraphEdit that triggers it is one of those covered here.

[AThousandShips]

Unsure about that case, there's no unhandled internal children there, and the connections_layer node is added in the constructor so it isn't duplicated, so don't think it is covered by this specific case

[Repiteo]

Thanks!

[AThousandShips]

Thank you!